You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "ilyasahsan123 (via GitHub)" <gi...@apache.org> on 2025/02/08 02:44:23 UTC
[PR] Use DistSQLDatabaseRuleQueryExecutorAssert in ShowShardingAlgorithmExecutorTest [shardingsphere]
ilyasahsan123 opened a new pull request, #34601:
URL: https://github.com/apache/shardingsphere/pull/34601
For #33142.
Changes proposed in this pull request:
- Use DistSQLDatabaseRuleQueryExecutorAssert in ShowShardingAlgorithmExecutorTest
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DistSQLDatabaseRuleQueryExecutorAssert in ShowShardingAlgorithmExecutorTest [shardingsphere]
Posted by "ilyasahsan123 (via GitHub)" <gi...@apache.org>.
ilyasahsan123 commented on PR #34601:
URL: https://github.com/apache/shardingsphere/pull/34601#issuecomment-2644447289
hi @terrymanu, if you have a time, could you please take a look? thanks in advance!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use DistSQLDatabaseRuleQueryExecutorAssert in ShowShardingAlgorithmExecutorTest [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #34601:
URL: https://github.com/apache/shardingsphere/pull/34601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org