You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/12/09 15:28:50 UTC

[GitHub] incubator-brooklyn pull request: Fix restart software process

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/380

    Fix restart software process

    - Previousy if you stopped the process, and then called restart() or start(), it would sometimes fail to reach service-up. This was because there was no change in serviceUpIndicators on stop+start, so service-up was not re-published as true.
    
    Builds on https://github.com/apache/incubator-brooklyn/pull/375

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn fix/restart-software-process

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/380.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #380
    
----
commit 8b1aed9a1cfbbc058ac672d65e9e35601194bd61
Author: Martin Harris <gi...@nakomis.com>
Date:   2014-12-08T13:07:47Z

    Adds optional parameter to stop effector for stopping underlying machine

commit 92aa39a6e04434f239853607836014c1f52adce2
Author: Aled Sage <al...@gmail.com>
Date:   2014-12-09T13:55:18Z

    Fix restart software process
    
    - Previousy if you stopped the process, and then called restart()
      or start(), it would sometimes fail to reach service-up. This was
      because there was no change in serviceUpIndicators on stop+start,
      so service-up was not re-published as true.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix restart software process

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/380#issuecomment-66320921
  
    Thanks @nakomis - merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix restart software process

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/380


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix restart software process

Posted by nakomis <gi...@git.apache.org>.

Github user nakomis commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/380#issuecomment-66320230
  
    Tests pass, good to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix restart software process

Posted by nakomis <gi...@git.apache.org>.

Github user nakomis commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/380#issuecomment-66318818
  
    Looks good, going to build & run the tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---