You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by rj...@apache.org on 2015/05/23 17:54:02 UTC

svn commit: r1681359 - in /tomcat/trunk/java/org/apache/catalina/util: LifecycleBase.java LocalStrings.properties

Author: rjung
Date: Sat May 23 15:54:02 2015
New Revision: 1681359

URL: http://svn.apache.org/r1681359
Log:
Revert r1681138. Was:

Log errors processing LifecycleListener events and continue rather
than allowing uncaught exception to propagate (BZ 57939).

"The bz issue needs a more careful look."

Modified:
    tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java
    tomcat/trunk/java/org/apache/catalina/util/LocalStrings.properties

Modified: tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java?rev=1681359&r1=1681358&r2=1681359&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java Sat May 23 15:54:02 2015
@@ -117,13 +117,7 @@ public abstract class LifecycleBase impl
         LifecycleEvent event = new LifecycleEvent(this, type, data);
         LifecycleListener interested[] = listeners;
         for (int i = 0; i < interested.length; i++) {
-            try {
-                interested[i].lifecycleEvent(event);
-            } catch (Throwable t) {
-                ExceptionUtils.handleThrowable(t);
-                log.error(sm.getString("lifecycleBase.listenerFail",
-                        type, interested[i].getClass().getName()), t);
-            }
+            interested[i].lifecycleEvent(event);
         }
     }
 

Modified: tomcat/trunk/java/org/apache/catalina/util/LocalStrings.properties
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/util/LocalStrings.properties?rev=1681359&r1=1681358&r2=1681359&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/util/LocalStrings.properties (original)
+++ tomcat/trunk/java/org/apache/catalina/util/LocalStrings.properties Sat May 23 15:54:02 2015
@@ -30,7 +30,6 @@ lifecycleBase.destroyFail=Failed to dest
 lifecycleBase.destroyStopFail=Calling stop() on failed component [{0}] to trigger clean-up did not complete.
 lifecycleBase.initFail=Failed to initialize component [{0}]
 lifecycleBase.invalidTransition=An invalid Lifecycle transition was attempted ([{0}]) for component [{1}] in state [{2}]
-lifecycleBase.listenerFail=Failed to processes [{0}] event for an instance of [{1}]
 lifecycleBase.setState=Setting state for [{0}] to [{1}]
 lifecycleBase.startFail=Failed to start component [{0}]
 lifecycleBase.stopFail=Failed to stop component [{0}]



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org