[jira] [Commented] (HADOOP-19646) S3A: Migrate hadoop-aws module from JUnit4 Assume to JUnit5 Assumptions

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-19646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18019574#comment-18019574 ] 

ASF GitHub Bot commented on HADOOP-19646:
-----------------------------------------

zhtttylz opened a new pull request, #7951:
URL: https://github.com/apache/hadoop/pull/7951

   ### Description of PR
   JIRA:HADOOP-19646. [Addendum] [JDK17] Migrate hadoop-aws module from JUnit4 Assume to JUnit5 Assumptions.
   
   ### How was this patch tested?
   Junit Test.
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




> S3A: Migrate hadoop-aws module from JUnit4 Assume to JUnit5 Assumptions
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-19646
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19646
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: hadoop-aws
>    Affects Versions: 3.5.0
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.5.0
>
>
> This task aims to migrate the test code in the {{hadoop-aws}} module from JUnit4's {{org.junit.Assume}} API to JUnit5's {{org.junit.jupiter.api.Assumptions}} API in order to unify the testing framework and improve maintainability.
> h4. Scope of changes:
>  * Replace usages of {{{}Assume.assumeTrue(...){}}}, {{{}Assume.assumeFalse(...){}}}, etc., with the corresponding methods from JUnit5, such as {{{}Assumptions.assumeTrue(...){}}};
>  * Ensure the assertion logic remains consistent with the original behavior;
>  * Update any outdated import statements referencing JUnit4's {{{}Assume{}}};
>  * Verify that all affected unit tests pass correctly under JUnit5.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org