You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Norman Maurer (JIRA)" <se...@james.apache.org> on 2011/06/27 12:26:47 UTC
[jira] [Created] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
API package in mailetcontainer-library should be moved to new module
---------------------------------------------------------------------
Key: JAMES-1282
URL: https://issues.apache.org/jira/browse/JAMES-1282
Project: JAMES Server
Issue Type: Task
Components: SpoolManager & Processors
Affects Versions: 3.0-M2
Reporter: Norman Maurer
Assignee: Norman Maurer
Fix For: 3.0-beta1
To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056698#comment-13056698 ]
Norman Maurer commented on JAMES-1282:
--------------------------------------
BTW, does it make more sense when also look at JAMES-1284 ?
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057176#comment-13057176 ]
Stefano Bagnara commented on JAMES-1282:
----------------------------------------
Can you explain what's the problem with OSGi and our current module layout: maybe once I understand this I will also understand your motivations :-)
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056689#comment-13056689 ]
Norman Maurer commented on JAMES-1282:
--------------------------------------
i think the loader interfaces make sense as it help to seperate the container from the rest. I understand that you spend your limited time on that but maybe I can show you later with the osgi stuff why I did it.At worst we will just "revert" it later
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055755#comment-13055755 ]
Stefano Bagnara commented on JAMES-1282:
----------------------------------------
I don't agre on the OSGi side: they must be separate modules only if you have different modules depending on them or alternative implementations. AFAIK we are not in this cases, now.
And I still think that "api" is not a good package name (and even worse module name) for that 3 interfaces + JMX stuff. I'll change my mind once I see an alternative implementation or some module depending on the api package and not on the remaining stuff (nothing changed since we agreed on the merge ;-) ).
We shouldn't add new modules unless it's strictly necessary: we worked a lot to reduce their number.
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Eric Charles (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055524#comment-13055524 ]
Eric Charles commented on JAMES-1282:
-------------------------------------
that's good as we will be use the api in other containers.
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055732#comment-13055732 ]
Norman Maurer commented on JAMES-1282:
--------------------------------------
I know we did. But it was an failure, at least in terms of OSGI. While working on the osgi integration I noticed we should better have a clean seperation here. Its also "bad" that we have abstract "base classes" and services in the same bundle. Like JamesMailSpooler and AbstractStateCompositeProcessor... In an ideal osgi world this kind of stuff should be separated
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Resolved] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norman Maurer resolved JAMES-1282.
----------------------------------
Resolution: Fixed
was done
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056609#comment-13056609 ]
Stefano Bagnara commented on JAMES-1282:
----------------------------------------
IMO a bunch of interfaces in a package named "api" doesn't make it a real API automatically. An api is much more than this (and IMO it doesn't even need interfaces or a package named api to be an api). That's why I think the previous solution (a single module) is still the best. I see no reasons to separate it into multiple modules so I would simply keep a single one. I looked at the code in that api package and I still think that it is not an api because I don't really understand why someone should program against that interfaces: we created that interfaces mainly because avalon worked that way (1 interface per service).
That said I won't veto the change, I just wanted to speak loudly about a change I don't like as soon as I saw it (the fact that I spent my few development time to merge them few months ago explain how much I feel this :-) ).
To change my mind I would have to see an alternative, (non camel based), implementation that still use some common code (I would write everything from scratch without reusing that "loader" stuff, simply because no other james module really care of that api, so it is really some small interface local to the spooler and doesn't create any cooperation/bridge/contract with the rest of james modules. So IMO that interfaces do not worth a module.
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055725#comment-13055725 ]
Stefano Bagnara commented on JAMES-1282:
----------------------------------------
I'm confused: we merged them 5 months ago in JAMES-1184
I don't think other containers will use *these* api. If we have api we think are common to containers then we should move them to the mailet api. And probably "api" is not even a good name for the package containing that classes (they are not api, IMO. and they are very "james" specific).
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056310#comment-13056310 ]
Norman Maurer commented on JAMES-1282:
--------------------------------------
You still don't convice me ;) I think the interfaces does not belong to the library. I MAY say that we could merge the mailetcontainer-library and the mailetcontainer-camel modul. So we would be back to the same module count. WDYT ?
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057435#comment-13057435 ]
Stefano Bagnara commented on JAMES-1282:
----------------------------------------
Can't we simply remove the mailetcontainer.xml from the library module?
BTW I still find the current structure better than what you propose, but this is just my opinion. You are on the code right now so I'm fine with your opinion to "win" against mine but I'll keep my opinion ;-)
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057441#comment-13057441 ]
Norman Maurer commented on JAMES-1282:
--------------------------------------
The mailetcontainer.xml is currently not located in the library module. But it should, as this allow us to deploy osgi bundles which contains all needed config to also start them. I still think it just make more sense to have everything which is needed for a service in one place. Think if it like a "self-contained jar/bundle". I think the OSGI deployment is mostly done, and Im still think that you will understand why I did this once I can show you how it work "in action". So I will just progress with "my plan" and we can review all this stuff if after all of this we still can't agree.
BTW, I appreciate all your comments ..
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] [Commented] (JAMES-1282) API package in
mailetcontainer-library should be moved to new module
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/JAMES-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057181#comment-13057181 ]
Norman Maurer commented on JAMES-1282:
--------------------------------------
The "problem" that I see is that we have a library module which contains API stuff ( I know you don't agree its a real API =P) and also provide services. This just don't feel right. Beside that we have two "modules" which depend on the same configuration file (mailetcontainer.xml) which is also not right. A configuration file should not be shared across modules. So we can include the configuration in the right module and just copy it over when bundle the distribution.
So I'm now proposing that we should only have this two modules:
* mailetcontainer-api
* mailetcontainer-camel (which is the only module that use mailetcontainer.xml)
Maybe the names are not optimal but thats easy to change.
Makes sense ?
> API package in mailetcontainer-library should be moved to new module
> ---------------------------------------------------------------------
>
> Key: JAMES-1282
> URL: https://issues.apache.org/jira/browse/JAMES-1282
> Project: JAMES Server
> Issue Type: Task
> Components: SpoolManager & Processors
> Affects Versions: 3.0-M2
> Reporter: Norman Maurer
> Assignee: Norman Maurer
> Fix For: 3.0-beta1
>
>
> To better seperate the implementation from the api its necessary to move the API package out of mailetcontainer-library to its extra module
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org