You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/20 14:00:41 UTC
[GitHub] [iceberg] pvary commented on a change in pull request #2123: Hive: Configuration sync between HMS and Iceberg table properties
pvary commented on a change in pull request #2123:
URL: https://github.com/apache/iceberg/pull/2123#discussion_r560980369
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -257,13 +257,16 @@ private Table newHmsTable() {
return newTable;
}
- private void setParameters(String newMetadataLocation, Table tbl, boolean hiveEngineEnabled) {
+ private void setParameters(String newMetadataLocation, Table tbl, TableMetadata meta, boolean hiveEngineEnabled) {
Review comment:
Why not use the meta.properties instead of the full `TableMetadata`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org