You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Sanjay Radia (JIRA)" <ji...@apache.org> on 2011/08/08 02:24:27 UTC

[jira] [Created] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Change RPC to allow multiple protocols including multuple versions of the same protocol
---------------------------------------------------------------------------------------

                 Key: HADOOP-7524
                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
             Project: Hadoop Common
          Issue Type: Improvement
            Reporter: Sanjay Radia
            Assignee: Sanjay Radia




--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080705#comment-13080705 ] 

Sanjay Radia commented on HADOOP-7524:
--------------------------------------

Attached patch allows the server to support multiple protocols including multiple versions of the same protocol.

* Server can add additional protocols and protocolImpls to a rpc server using #RPC.addProtocol
* Server side keeps a list of protocols and versions
* Can add an annotation to a protocol to give its protocol name (default is the class name as before) this
allows one to use different classes to implement different versions of the same protocol.
* Better support for Mixins (call now contains the declaring class along with method name).
* Inherited interfaces automatically added (this allows compatibility with old usage and also allows mixins)
* See ipc/TestMulitpleProtocolServer for examples

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098203#comment-13098203 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #808 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/808/])
    HDFS-2310. TestBackupNode fails since HADOOP-7524 went in. Contributed by Ivan Kelly.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165461
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Status: Patch Available  (was: Open)

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, rpc2.patch, rpc2_trunk.patch, rpc3.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092079#comment-13092079 ] 

Hadoop QA commented on HADOOP-7524:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12491839/rpc6WithoutMR.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 11 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//console

This message is automatically generated.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136328#comment-13136328 ] 

Todd Lipcon commented on HADOOP-7524:
-------------------------------------

Sanjay, are you still working on merging this to 0.23? Still intending that it should be merged?
                
> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100523#comment-13100523 ] 

Sanjay Radia commented on HADOOP-7524:
--------------------------------------

we should backport this to 0.23

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109481#comment-13109481 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #807 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/807/])
    HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097939#comment-13097939 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #785 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/785/])
    HDFS-2310. TestBackupNode fails since HADOOP-7524 went in. Contributed by Ivan Kelly.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165461
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Status: Patch Available  (was: Open)

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Attachment: rpc8WithoutMR.patch

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Status: Open  (was: Patch Available)

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Status: Patch Available  (was: Open)

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087784#comment-13087784 ] 

Hadoop QA commented on HADOOP-7524:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12490967/rpc3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 11 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/57//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/57//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/57//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/57//console

This message is automatically generated.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, rpc2.patch, rpc2_trunk.patch, rpc3.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091637#comment-13091637 ] 

Hadoop QA commented on HADOOP-7524:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12491749/rpc6.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 11 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/88//console

This message is automatically generated.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100195#comment-13100195 ] 

Vinod Kumar Vavilapalli commented on HADOOP-7524:
-------------------------------------------------

This patch has broken a test in MapReduce. Please see MAPREDUCE-2942. You can see the test failure at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/622/testReport/.

I do see this as marked as an incompatible change. If this cannot really be done in a backwards compatible way, I think we should remove those APIs which are marked deprecated, for e.g {{Server getServer(final Object instance, final String bindAddress, final int port, Configuration conf) }},  which won't work at all.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089984#comment-13089984 ] 

Todd Lipcon commented on HADOOP-7524:
-------------------------------------

I tried running HDFS trunk when this patch is applied to common, and it fails with the following:

java.io.IOException: Unknown protocol to name node: org.apache.hadoop.hdfs.server.protocol.NamenodeProtocols
	at org.apache.hadoop.hdfs.server.namenode.NameNode.getProtocolVersion(NameNode.java:196)
	at org.apache.hadoop.ipc.WritableRpcEngine$Server.registerProtocolAndImpl(WritableRpcEngine.java:387)
	at org.apache.hadoop.ipc.WritableRpcEngine$Server.<init>(WritableRpcEngine.java:544)
	at org.apache.hadoop.ipc.WritableRpcEngine.getServer(WritableRpcEngine.java:329)
	at org.apache.hadoop.ipc.RPC.getServer(RPC.java:565)
	at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:431)

so I think we need a corresponding patch for HDFS and MR, or we need a workaround on the Common side.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Status: Patch Available  (was: Open)

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Status: Patch Available  (was: Open)

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Status: Open  (was: Patch Available)

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088030#comment-13088030 ] 

Todd Lipcon commented on HADOOP-7524:
-------------------------------------

hm, something strange went on with this test-patch build. I kicked it to go again, Tom and I are looking at it.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081250#comment-13081250 ] 

Todd Lipcon commented on HADOOP-7524:
-------------------------------------

- the word Multiple is misspelled in {{TestMulitpleProtocolServer}}
- Perhaps rename {{ProtocolAnnotation}} to {{RPCProtocolName}} or maybe {{ProtocolInfo}} to be more consistent with the other annotations we use here (like KerberosInfo and TokenInfo)
- Some typos in the javadoc of {{ProtocolAnnotation}}:
-- "The protocol name is *used to when* a client..."
-- "*Bt* default the clss"
-- Missing '.' at end of first paragraph
- {{String protocolName()}} should be indented in the body of this annotation class
- In the test case, maybe the different methods should return strings - eg:
{code}
String ping() {
  return "V1 implementation";
}
{code}
so that you can assert that the correct implementation has been delegated to?

- typo in method name: {{getProtocolIntefaces}}
- use javadoc style comments for the descriptions of ProtoNameVer, ProtoClassProtoImpl, etc.
- missing indentation where RPC.VersionMismatch is thrown
- typo in javadoc: "the impl of the protocol - *is is* called"

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, rpc2.patch, rpc2_trunk.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100522#comment-13100522 ] 

Sanjay Radia commented on HADOOP-7524:
--------------------------------------

It is incompatible only wrt to wire protocol, public APIs apis are compatible.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Status: Open  (was: Patch Available)

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Attachment: rpc6.patch

Updated patch:
* Incorporates Todd's nits
* Fixes the HDFS test failure - added code to ignore protocol interfaces that throw exception on getProtocolVersion() as does NamenodeProotocol.
* Minor fixes to make MR2's rpc work.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Attachment: rpc6WithoutMR.patch

rpc6WithoutMR.path removes the MR related changes which need to be submitted as a MR jira.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109468#comment-13109468 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #837 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/837/])
    HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-7524:
--------------------------------

    Attachment: rpc4.txt
                nits.txt

Hey Sanjay. Looks great. I had a few nitpicks, but rather than list them here and have to go back and forth I just formatted them as a diff. (nits.txt is just the delta, rpc4.txt is your patch with the delta applied)

+1 w/ the nits fixed.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Attachment: rpc7WithoutMR.patch

New patch: Minor improvements to logging.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085258#comment-13085258 ] 

Sanjay Radia commented on HADOOP-7524:
--------------------------------------

I will incorporate the feedback and post a new patch.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, rpc2.patch, rpc2_trunk.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090352#comment-13090352 ] 

Sanjay Radia commented on HADOOP-7524:
--------------------------------------

I have the fix for the above. However I another test  fails in HDFS that I am investigating -  it appears unrelated.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Hadoop Flags: [Incompatible change]

writableRpcVersion has changed.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed the patch (together with MapReduce-2887)

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109263#comment-13109263 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #944 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/944/])
    HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multiple versions of the same protocol

Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhihong Ted Yu updated HADOOP-7524:
-----------------------------------

    Summary: Change RPC to allow multiple protocols including multiple versions of the same protocol  (was: Change RPC to allow multiple protocols including multuple versions of the same protocol)
    
> Change RPC to allow multiple protocols including multiple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 2.0.0-alpha
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119555#comment-13119555 ] 

Sanjay Radia commented on HADOOP-7524:
--------------------------------------

Yes I am intending this to do into 23.  Agree about HADOOP-7693.
I was waiting for HDFS-2181; but strictly speaking I don't need to wait for that.

Is the patch that was committed for HDFS-2298 the simpler one you talk about?
                
> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-7524:
-------------------------------------------

    Fix Version/s: 0.23.3

I have merged this to 0.23.
                
> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0, 0.23.3
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HADOOP-7524:
--------------------------------

    Affects Version/s: 0.24.0
        Fix Version/s: 0.24.0

Marking as 0.24 since it was only committed to that branch.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Attachment: rpc2.patch

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: rpc2.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Status: Open  (was: Patch Available)

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Issue Type: Sub-task  (was: Improvement)
        Parent: HADOOP-7775
    
> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-7524:
-------------------------------------------

    Component/s: ipc

- Change RPC.Server.addProtocol(..) as below.
{code}
public abstract <PROTO extends VersionedProtocol, IMPL extends PROTO>
  Server addProtocol(Class<PROTO> protocolClass, IMPL protocolImpl
  ) throws IOException;
{code}

- In WritableRpcEngine.getSuperInterfaces(..),
-* check if each class is a subclass of VersionedProtocol before adding it to the list.
-* Change it to private.

- Add final to WritableRpcEngine.writableRpcVersion.

- Use junit4 Assert in TestMulitpleProtocolServer (i.e. org.junit.Assert instead of junit.framework.Assert)

- Rename protocolImplSet to protocolImplMap since it is a Map.

- Remove the first "this.declaringClassProtocolName = ..." below.
{code}
@@ -87,7 +121,9 @@
         }
         this.clientMethodsHash = ProtocolSignature.getFingerprint(method
             .getDeclaringClass().getMethods());
+        this.declaringClassProtocolName = RPC.getProtocolName(method.getDeclaringClass());
       }
+      this.declaringClassProtocolName = RPC.getProtocolName(method.getDeclaringClass());
     }
{code}

- There are two findbugs warnings in ProtoNameVer.equals(..); see [the attached report|https://issues.apache.org/jira/secure/attachment/12489657/newPatchFindbugsWarnings.html].

- VerProtocolImpl.getSupportedProtocolVersions(..) is unused.

- Revert the (write space) change in AvroRpcEngine.


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, rpc2.patch, rpc2_trunk.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093367#comment-13093367 ] 

Hadoop QA commented on HADOOP-7524:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12492168/rpc7WithoutMR.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 11 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 1048 javac compiler warnings (more than the trunk's current 1047 warnings).

    -1 findbugs.  The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//console

This message is automatically generated.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097661#comment-13097661 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #842 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/842/])
    HDFS-2310. TestBackupNode fails since HADOOP-7524 went in. Contributed by Ivan Kelly.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165461
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088287#comment-13088287 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-7524:
------------------------------------------------

Todd, your changes looked good to me but there were javadoc warnings.  Could you take a look?

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Attachment: rpc3.patch

Updated patch

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, rpc2.patch, rpc2_trunk.patch, rpc3.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088020#comment-13088020 ] 

Hadoop QA commented on HADOOP-7524:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12491011/rpc4.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 11 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 3 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:


    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//artifact/trunk/target/newPatchFindbugsWarningshadoop-hdfs.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//console

This message is automatically generated.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096513#comment-13096513 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #825 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/825/])
    HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094336#comment-13094336 ] 

Hadoop QA commented on HADOOP-7524:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12492424/rpc8WithoutMR.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 11 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//console

This message is automatically generated.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109259#comment-13109259 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1005 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1005/])
    HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096652#comment-13096652 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #805 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/805/])
    HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sanjay Radia updated HADOOP-7524:
---------------------------------

    Attachment: rpcCommitted.patch

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097670#comment-13097670 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #909 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/909/])
    HDFS-2310. TestBackupNode fails since HADOOP-7524 went in. Contributed by Ivan Kelly.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165461
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096523#comment-13096523 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #835 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/835/])
    HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088530#comment-13088530 ] 

Todd Lipcon commented on HADOOP-7524:
-------------------------------------

Something strange is going on with the QA bot, if you look at the Console output above. I tried to kick another build manually, but it doesn't seem to have posted results here. When I try to load the Hudson web page at the moment, it's just hanging. I will try to look into it tomorrow.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096517#comment-13096517 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #902 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/902/])
    HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-7524:
-------------------------------------------

    Attachment: newPatchFindbugsWarnings.html

newPatchFindbugsWarnings.html: for rpc2_trunk.patch.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, rpc2.patch, rpc2_trunk.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109258#comment-13109258 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #927 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/927/])
    HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096646#comment-13096646 ] 

Hudson commented on HADOOP-7524:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #781 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/781/])
    HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java


> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-7524:
-------------------------------------------

    Attachment: rpc2_trunk.patch

Hi Sanjay, rpc2.patch patch does not apply to trunk.

rpc2_trunk.patch: updated with trunk.

> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: rpc2.patch, rpc2_trunk.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7524) Change RPC to allow multiple protocols including multuple versions of the same protocol

Posted by "Doug Cutting (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119625#comment-13119625 ] 

Doug Cutting commented on HADOOP-7524:
--------------------------------------

> Is the patch that was committed for HDFS-2298 the simpler one you talk about?

Yes.

                
> Change RPC to allow multiple protocols including multuple versions of the same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>             Fix For: 0.24.0
>
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, rpc2_trunk.patch, rpc3.patch, rpc4.txt, rpc6.patch, rpc6WithoutMR.patch, rpc7WithoutMR.patch, rpc8WithoutMR.patch, rpcCommitted.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira