[GitHub] [camel-kamelets] zregvart commented on a diff in pull request #897: Update non-working examples in Kamelet Catalog docs

[GitBox <gi...@apache.org>]

zregvart commented on code in PR #897:
URL: https://github.com/apache/camel-kamelets/pull/897#discussion_r859106570


##########
docs/modules/ROOT/examples/js/kamelets.js:
##########
@@ -16,6 +16,8 @@
  */
 
 const util = require('camel-website-util')
+const fs = require('fs')
+const yaml = require('js-yaml');

Review Comment:
   If you're importing here you also need to adjust package.json in camel-website, i.e. add `js-yaml` to `devDependencies`. You also need to make sure that the `js-yaml` is placed in the PnP cache. Or avoid using `js-yaml` or any non-managed dependency.
   
   I can see the net positive of having them versioned within the module. But I don't see a way for them to be tested, debugged or linted here. So until this is figured out I can't recommend doing this here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org