[jira] [Updated] (SLING-3216) BindingsValuesProviders do not respect service dynamics

["Justin Edelson (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Justin Edelson updated SLING-3216:
----------------------------------

    Attachment: SLING-3216.patch

There's actually two different problems:
1) a change to a BVP doesn't cause the script cache to be refresh. The best solution I can come up with is to send an event.
2) unregistered BVPs aren't actually removed from the language-specific maps because the remove() call is passing in the service, not the serviceId.

Attached patch handles both. However, it causes the Scripting Core ITs to fail. [~bdelacretaz] can you take a look as to why? I can't figure it out.

> BindingsValuesProviders do not respect service dynamics
> -------------------------------------------------------
>
>                 Key: SLING-3216
>                 URL: https://issues.apache.org/jira/browse/SLING-3216
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>            Reporter: Justin Edelson
>            Priority: Critical
>         Attachments: SLING-3216.patch
>
>
> Unregistering a BindingsValuesProvider does not cause the references to it in DefaultSlingScript instances cached by the ServletResolver to be refreshed. Simiarly, registering a new BVP does not show up in cached instances.



--
This message was sent by Atlassian JIRA
(v6.1#6144)