You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Shane Isbell (JIRA)" <ji...@codehaus.org> on 2008/03/04 19:50:31 UTC
[jira] Created: (MNG-3430) Toolchain doesn't match Toolchain
extensions
Toolchain doesn't match Toolchain extensions
--------------------------------------------
Key: MNG-3430
URL: http://jira.codehaus.org/browse/MNG-3430
Project: Maven 2
Issue Type: Bug
Affects Versions: 2.0.9
Reporter: Shane Isbell
Priority: Minor
Toolchain uses null key within storing toolchains in Maven Session, which causes extensions not to match.
Specifically, this problem occurs in the DefaultToolchainManager.storeToolchainToBuildContext method. When storing into context
context.put( getStorageKey( toolchain.getType() ), toolchain.getModel() );
toolchain.getType() always returns null. Using toolchain.getModel().getType() will return the correct type and fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-3430) Toolchain doesn't match Toolchain
extensions
Posted by "Milos Kleint (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Milos Kleint closed MNG-3430.
-----------------------------
Resolution: Fixed
Fix Version/s: 2.1-alpha-1
2.0.x
done:
http://svn.apache.org/viewvc?rev=635690&view=rev
> Toolchain doesn't match Toolchain extensions
> --------------------------------------------
>
> Key: MNG-3430
> URL: http://jira.codehaus.org/browse/MNG-3430
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 2.0.9
> Reporter: Shane Isbell
> Assignee: Milos Kleint
> Priority: Minor
> Fix For: 2.0.x, 2.1-alpha-1
>
>
> Toolchain uses null key within storing toolchains in Maven Session, which causes extensions not to match.
> Specifically, this problem occurs in the DefaultToolchainManager.storeToolchainToBuildContext method. When storing into context
> context.put( getStorageKey( toolchain.getType() ), toolchain.getModel() );
> toolchain.getType() always returns null. Using toolchain.getModel().getType() will return the correct type and fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3430) Toolchain doesn't match Toolchain
extensions
Posted by "Paul Benedict (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126764 ]
Paul Benedict commented on MNG-3430:
------------------------------------
"Affects version" is 2.0.9 -- should Fix Version also be 2.0.9 not 2.0.x?
> Toolchain doesn't match Toolchain extensions
> --------------------------------------------
>
> Key: MNG-3430
> URL: http://jira.codehaus.org/browse/MNG-3430
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 2.0.9
> Reporter: Shane Isbell
> Assignee: Milos Kleint
> Priority: Minor
> Fix For: 2.0.x, 2.1-alpha-1
>
>
> Toolchain uses null key within storing toolchains in Maven Session, which causes extensions not to match.
> Specifically, this problem occurs in the DefaultToolchainManager.storeToolchainToBuildContext method. When storing into context
> context.put( getStorageKey( toolchain.getType() ), toolchain.getModel() );
> toolchain.getType() always returns null. Using toolchain.getModel().getType() will return the correct type and fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-3430) Toolchain doesn't match Toolchain
extensions
Posted by "Milos Kleint (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126761 ]
Milos Kleint commented on MNG-3430:
-----------------------------------
the factory should use this constructor
protected DefaultToolchain( ToolchainModel model, String type, Logger logger )
for some reason the incomplete
protected DefaultToolchain( ToolchainModel model, Logger logger )
constructor is also present.
What about I keep both constructors supported and the getType() method does this:
return type != null ? type : model.getType();
> Toolchain doesn't match Toolchain extensions
> --------------------------------------------
>
> Key: MNG-3430
> URL: http://jira.codehaus.org/browse/MNG-3430
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 2.0.9
> Reporter: Shane Isbell
> Assignee: Milos Kleint
> Priority: Minor
>
> Toolchain uses null key within storing toolchains in Maven Session, which causes extensions not to match.
> Specifically, this problem occurs in the DefaultToolchainManager.storeToolchainToBuildContext method. When storing into context
> context.put( getStorageKey( toolchain.getType() ), toolchain.getModel() );
> toolchain.getType() always returns null. Using toolchain.getModel().getType() will return the correct type and fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3430) Toolchain doesn't match Toolchain
extensions
Posted by "Milos Kleint (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Milos Kleint updated MNG-3430:
------------------------------
Fix Version/s: 2.0.9
well, possibly, but 2.0.9 was not released yet anyway..
> Toolchain doesn't match Toolchain extensions
> --------------------------------------------
>
> Key: MNG-3430
> URL: http://jira.codehaus.org/browse/MNG-3430
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 2.0.9
> Reporter: Shane Isbell
> Assignee: Milos Kleint
> Priority: Minor
> Fix For: 2.0.9, 2.0.x, 2.1-alpha-1
>
>
> Toolchain uses null key within storing toolchains in Maven Session, which causes extensions not to match.
> Specifically, this problem occurs in the DefaultToolchainManager.storeToolchainToBuildContext method. When storing into context
> context.put( getStorageKey( toolchain.getType() ), toolchain.getModel() );
> toolchain.getType() always returns null. Using toolchain.getModel().getType() will return the correct type and fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-3430) Toolchain doesn't match Toolchain
extensions
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-3430:
------------------------------
Fix Version/s: (was: 2.1-alpha-1)
(was: 2.0.x)
> Toolchain doesn't match Toolchain extensions
> --------------------------------------------
>
> Key: MNG-3430
> URL: http://jira.codehaus.org/browse/MNG-3430
> Project: Maven 2
> Issue Type: Bug
> Affects Versions: 2.0.9
> Reporter: Shane Isbell
> Assignee: Milos Kleint
> Priority: Minor
> Fix For: 2.0.9
>
>
> Toolchain uses null key within storing toolchains in Maven Session, which causes extensions not to match.
> Specifically, this problem occurs in the DefaultToolchainManager.storeToolchainToBuildContext method. When storing into context
> context.put( getStorageKey( toolchain.getType() ), toolchain.getModel() );
> toolchain.getType() always returns null. Using toolchain.getModel().getType() will return the correct type and fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira