You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Randy Hudson (JIRA)" <ji...@apache.org> on 2011/05/26 16:16:47 UTC
[jira] [Created] (SHINDIG-1540) Message string in MessageBundle
gets mangled (trimmed) in shindig
Message string in MessageBundle gets mangled (trimmed) in shindig
-----------------------------------------------------------------
Key: SHINDIG-1540
URL: https://issues.apache.org/jira/browse/SHINDIG-1540
Project: Shindig
Issue Type: Bug
Components: Java
Reporter: Randy Hudson
I have a gadget whose message bundle includes the following entry:
<msg name="orange" desc="Color, approximately #E69B1E">
orange
</msg>
The value of that message should be "\norange\n", but shindig appears to be trimming the whitespace around the message's value.
Shindig is not following the spec, which states that the msg element extends xs:string, and NOT xs:normalizedString:
<xs:element name="messagebundle">
<xs:complexType>
<xs:sequence>
<xs:element name="msg" minOccurs="0" maxOccurs="unbounded">
<xs:complexType>
<xs:simpleContent>
<xs:extension base="xs:string">
<xs:attribute name="name" type="xs:string" use="required"/>
<xs:attribute name="desc" type="xs:string" use="optional"/>
</xs:extension>
</xs:simpleContent>
</xs:complexType>
</xs:element>
</xs:sequence>
</xs:complexType>
</xs:element>
See:
http://www.w3schools.com/Schema/schema_dtypes_string.asp
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1540) Message string in MessageBundle
gets mangled (trimmed) in shindig
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter updated SHINDIG-1540:
---------------------------------
Fix Version/s: (was: 2.5.0)
2.5.0-beta2
> Message string in MessageBundle gets mangled (trimmed) in shindig
> -----------------------------------------------------------------
>
> Key: SHINDIG-1540
> URL: https://issues.apache.org/jira/browse/SHINDIG-1540
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Randy Hudson
> Fix For: 2.5.0-beta2
>
> Attachments: shindig-1540.patch
>
>
> I have a gadget whose message bundle includes the following entry:
> <msg name="orange" desc="Color, approximately #E69B1E">
> orange
> </msg>
> The value of that message should be "\norange\n", but shindig appears to be trimming the whitespace around the message's value.
> Shindig is not following the spec, which states that the msg element extends xs:string, and NOT xs:normalizedString:
> <xs:element name="messagebundle">
> <xs:complexType>
> <xs:sequence>
> <xs:element name="msg" minOccurs="0" maxOccurs="unbounded">
> <xs:complexType>
> <xs:simpleContent>
> <xs:extension base="xs:string">
> <xs:attribute name="name" type="xs:string" use="required"/>
> <xs:attribute name="desc" type="xs:string" use="optional"/>
> </xs:extension>
> </xs:simpleContent>
> </xs:complexType>
> </xs:element>
> </xs:sequence>
> </xs:complexType>
> </xs:element>
> See:
> http://www.w3schools.com/Schema/schema_dtypes_string.asp
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1540) Message string in MessageBundle
gets mangled (trimmed) in shindig
Posted by "Ran Jiang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256399#comment-13256399 ]
Ran Jiang commented on SHINDIG-1540:
------------------------------------
This is due to trim() method being called in MessageBundle.java
line 172: "messages.put(name, sw.toString().trim());"
> Message string in MessageBundle gets mangled (trimmed) in shindig
> -----------------------------------------------------------------
>
> Key: SHINDIG-1540
> URL: https://issues.apache.org/jira/browse/SHINDIG-1540
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Randy Hudson
> Attachments: shindig-1540.patch
>
>
> I have a gadget whose message bundle includes the following entry:
> <msg name="orange" desc="Color, approximately #E69B1E">
> orange
> </msg>
> The value of that message should be "\norange\n", but shindig appears to be trimming the whitespace around the message's value.
> Shindig is not following the spec, which states that the msg element extends xs:string, and NOT xs:normalizedString:
> <xs:element name="messagebundle">
> <xs:complexType>
> <xs:sequence>
> <xs:element name="msg" minOccurs="0" maxOccurs="unbounded">
> <xs:complexType>
> <xs:simpleContent>
> <xs:extension base="xs:string">
> <xs:attribute name="name" type="xs:string" use="required"/>
> <xs:attribute name="desc" type="xs:string" use="optional"/>
> </xs:extension>
> </xs:simpleContent>
> </xs:complexType>
> </xs:element>
> </xs:sequence>
> </xs:complexType>
> </xs:element>
> See:
> http://www.w3schools.com/Schema/schema_dtypes_string.asp
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1540) Message string in MessageBundle
gets mangled (trimmed) in shindig
Posted by "Ran Jiang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ran Jiang updated SHINDIG-1540:
-------------------------------
Attachment: shindig-1540.patch
> Message string in MessageBundle gets mangled (trimmed) in shindig
> -----------------------------------------------------------------
>
> Key: SHINDIG-1540
> URL: https://issues.apache.org/jira/browse/SHINDIG-1540
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Randy Hudson
> Attachments: shindig-1540.patch
>
>
> I have a gadget whose message bundle includes the following entry:
> <msg name="orange" desc="Color, approximately #E69B1E">
> orange
> </msg>
> The value of that message should be "\norange\n", but shindig appears to be trimming the whitespace around the message's value.
> Shindig is not following the spec, which states that the msg element extends xs:string, and NOT xs:normalizedString:
> <xs:element name="messagebundle">
> <xs:complexType>
> <xs:sequence>
> <xs:element name="msg" minOccurs="0" maxOccurs="unbounded">
> <xs:complexType>
> <xs:simpleContent>
> <xs:extension base="xs:string">
> <xs:attribute name="name" type="xs:string" use="required"/>
> <xs:attribute name="desc" type="xs:string" use="optional"/>
> </xs:extension>
> </xs:simpleContent>
> </xs:complexType>
> </xs:element>
> </xs:sequence>
> </xs:complexType>
> </xs:element>
> See:
> http://www.w3schools.com/Schema/schema_dtypes_string.asp
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1540) Message string in MessageBundle
gets mangled (trimmed) in shindig
Posted by "Henry Saputra (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256714#comment-13256714 ]
Henry Saputra commented on SHINDIG-1540:
----------------------------------------
+1
> Message string in MessageBundle gets mangled (trimmed) in shindig
> -----------------------------------------------------------------
>
> Key: SHINDIG-1540
> URL: https://issues.apache.org/jira/browse/SHINDIG-1540
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Randy Hudson
> Attachments: shindig-1540.patch
>
>
> I have a gadget whose message bundle includes the following entry:
> <msg name="orange" desc="Color, approximately #E69B1E">
> orange
> </msg>
> The value of that message should be "\norange\n", but shindig appears to be trimming the whitespace around the message's value.
> Shindig is not following the spec, which states that the msg element extends xs:string, and NOT xs:normalizedString:
> <xs:element name="messagebundle">
> <xs:complexType>
> <xs:sequence>
> <xs:element name="msg" minOccurs="0" maxOccurs="unbounded">
> <xs:complexType>
> <xs:simpleContent>
> <xs:extension base="xs:string">
> <xs:attribute name="name" type="xs:string" use="required"/>
> <xs:attribute name="desc" type="xs:string" use="optional"/>
> </xs:extension>
> </xs:simpleContent>
> </xs:complexType>
> </xs:element>
> </xs:sequence>
> </xs:complexType>
> </xs:element>
> See:
> http://www.w3schools.com/Schema/schema_dtypes_string.asp
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1540) Message string in MessageBundle
gets mangled (trimmed) in shindig
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256411#comment-13256411 ]
jiraposter@reviews.apache.org commented on SHINDIG-1540:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4786/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
line 172 in MessageBundle.java:
"message.put(name, sw.toString().trim())"
The "trim()" method trim the whitespace around the message's value, which result in returning the wrong value.
This addresses bug SHINDIG-1540.
https://issues.apache.org/jira/browse/SHINDIG-1540
Diffs
-----
Diff: https://reviews.apache.org/r/4786/diff
Testing
-------
Done
Thanks,
Ran
> Message string in MessageBundle gets mangled (trimmed) in shindig
> -----------------------------------------------------------------
>
> Key: SHINDIG-1540
> URL: https://issues.apache.org/jira/browse/SHINDIG-1540
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Randy Hudson
> Attachments: shindig-1540.patch
>
>
> I have a gadget whose message bundle includes the following entry:
> <msg name="orange" desc="Color, approximately #E69B1E">
> orange
> </msg>
> The value of that message should be "\norange\n", but shindig appears to be trimming the whitespace around the message's value.
> Shindig is not following the spec, which states that the msg element extends xs:string, and NOT xs:normalizedString:
> <xs:element name="messagebundle">
> <xs:complexType>
> <xs:sequence>
> <xs:element name="msg" minOccurs="0" maxOccurs="unbounded">
> <xs:complexType>
> <xs:simpleContent>
> <xs:extension base="xs:string">
> <xs:attribute name="name" type="xs:string" use="required"/>
> <xs:attribute name="desc" type="xs:string" use="optional"/>
> </xs:extension>
> </xs:simpleContent>
> </xs:complexType>
> </xs:element>
> </xs:sequence>
> </xs:complexType>
> </xs:element>
> See:
> http://www.w3schools.com/Schema/schema_dtypes_string.asp
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1540) Message string in MessageBundle
gets mangled (trimmed) in shindig
Posted by "Stanton Sievers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257429#comment-13257429 ]
Stanton Sievers commented on SHINDIG-1540:
------------------------------------------
Committed revision 1327901.
> Message string in MessageBundle gets mangled (trimmed) in shindig
> -----------------------------------------------------------------
>
> Key: SHINDIG-1540
> URL: https://issues.apache.org/jira/browse/SHINDIG-1540
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Reporter: Randy Hudson
> Fix For: 2.5.0
>
> Attachments: shindig-1540.patch
>
>
> I have a gadget whose message bundle includes the following entry:
> <msg name="orange" desc="Color, approximately #E69B1E">
> orange
> </msg>
> The value of that message should be "\norange\n", but shindig appears to be trimming the whitespace around the message's value.
> Shindig is not following the spec, which states that the msg element extends xs:string, and NOT xs:normalizedString:
> <xs:element name="messagebundle">
> <xs:complexType>
> <xs:sequence>
> <xs:element name="msg" minOccurs="0" maxOccurs="unbounded">
> <xs:complexType>
> <xs:simpleContent>
> <xs:extension base="xs:string">
> <xs:attribute name="name" type="xs:string" use="required"/>
> <xs:attribute name="desc" type="xs:string" use="optional"/>
> </xs:extension>
> </xs:simpleContent>
> </xs:complexType>
> </xs:element>
> </xs:sequence>
> </xs:complexType>
> </xs:element>
> See:
> http://www.w3schools.com/Schema/schema_dtypes_string.asp
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira