You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2014/02/21 23:15:43 UTC
Review Request 18379: [HELIX-390] Force message handler registration even
when ZK connection state is flaky
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18379/
-----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
Bugs: HELIX-390
Repository: helix-git
Description
-------
commit c48278065c8f119fe92aba1613936c362d470299
Author: Kanak Biscuitwala <ka...@apache.org>
Date: Fri Feb 21 14:13:21 2014 -0800
[HELIX-390] Force message handler registration even when ZK connection state is flaky
:100644 100644 da266f9... 42c4f11... M helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java
:100644 100644 56e4be8... 425b2da... M helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java
:100644 100644 422d35e... b7cb3cb... M helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java da266f9
helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java 56e4be8
helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java 422d35e
Diff: https://reviews.apache.org/r/18379/diff/
Testing
-------
Thanks,
Kanak Biscuitwala
Re: Review Request 18379: [HELIX-390] Force message handler registration
even when ZK connection state is flaky
Posted by Sandeep Nayak <sa...@chegg.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18379/#review35215
-----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java
<https://reviews.apache.org/r/18379/#comment65669>
I dont think we can change the scope of this method as such. It was a public API and it will break existing users. Deprecate it and delegate to a private method so that it can be removed.
That is unfortunately the nature of having public APIs, they cannot just be removed.
- Sandeep Nayak
On Feb. 21, 2014, 10:15 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18379/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 10:15 p.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-390
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit c48278065c8f119fe92aba1613936c362d470299
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Fri Feb 21 14:13:21 2014 -0800
>
> [HELIX-390] Force message handler registration even when ZK connection state is flaky
>
> :100644 100644 da266f9... 42c4f11... M helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java
> :100644 100644 56e4be8... 425b2da... M helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java
> :100644 100644 422d35e... b7cb3cb... M helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java da266f9
> helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java 56e4be8
> helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java 422d35e
>
> Diff: https://reviews.apache.org/r/18379/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>
Re: Review Request 18379: [HELIX-390] Force message handler registration
even when ZK connection state is flaky
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18379/#review35233
-----------------------------------------------------------
Ship it!
Ship It!
- Zhen Zhang
On Feb. 22, 2014, 6:41 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18379/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2014, 6:41 p.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-390
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit c48278065c8f119fe92aba1613936c362d470299
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Fri Feb 21 14:13:21 2014 -0800
>
> [HELIX-390] Force message handler registration even when ZK connection state is flaky
>
> :100644 100644 da266f9... 42c4f11... M helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java
> :100644 100644 56e4be8... 425b2da... M helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java
> :100644 100644 422d35e... b7cb3cb... M helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java da266f9
> helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java 56e4be8
> helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java 422d35e
>
> Diff: https://reviews.apache.org/r/18379/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>
Re: Review Request 18379: [HELIX-390] Force message handler registration
even when ZK connection state is flaky
Posted by Kanak Biscuitwala <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18379/
-----------------------------------------------------------
(Updated Feb. 22, 2014, 10:41 a.m.)
Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
Bugs: HELIX-390
Repository: helix-git
Description
-------
commit c48278065c8f119fe92aba1613936c362d470299
Author: Kanak Biscuitwala <ka...@apache.org>
Date: Fri Feb 21 14:13:21 2014 -0800
[HELIX-390] Force message handler registration even when ZK connection state is flaky
:100644 100644 da266f9... 42c4f11... M helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java
:100644 100644 56e4be8... 425b2da... M helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java
:100644 100644 422d35e... b7cb3cb... M helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java
Diffs (updated)
-----
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java da266f9
helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java 56e4be8
helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java 422d35e
Diff: https://reviews.apache.org/r/18379/diff/
Testing
-------
Thanks,
Kanak Biscuitwala
Re: Review Request 18379: [HELIX-390] Force message handler registration
even when ZK connection state is flaky
Posted by Kanak Biscuitwala <ka...@apache.org>.
> On Feb. 21, 2014, 3:47 p.m., Sandeep Nayak wrote:
> > helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java, line 292
> > <https://reviews.apache.org/r/18379/diff/1/?file=500601#file500601line292>
> >
> > Why are we giving out the HelixTaskExecutor here? What happens if someone calls shutdown on it?
> >
> > This needs to be deprecated/removed as its a huge risk.
I agree with this in principle, but it requires significant refactoring, and this patch is just meant to be a bugfix.
- Kanak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18379/#review35216
-----------------------------------------------------------
On Feb. 22, 2014, 10:41 a.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18379/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2014, 10:41 a.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-390
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit c48278065c8f119fe92aba1613936c362d470299
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Fri Feb 21 14:13:21 2014 -0800
>
> [HELIX-390] Force message handler registration even when ZK connection state is flaky
>
> :100644 100644 da266f9... 42c4f11... M helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java
> :100644 100644 56e4be8... 425b2da... M helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java
> :100644 100644 422d35e... b7cb3cb... M helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java da266f9
> helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java 56e4be8
> helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java 422d35e
>
> Diff: https://reviews.apache.org/r/18379/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>
Re: Review Request 18379: [HELIX-390] Force message handler registration
even when ZK connection state is flaky
Posted by Sandeep Nayak <sa...@chegg.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18379/#review35216
-----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java
<https://reviews.apache.org/r/18379/#comment65670>
Why are we giving out the HelixTaskExecutor here? What happens if someone calls shutdown on it?
This needs to be deprecated/removed as its a huge risk.
- Sandeep Nayak
On Feb. 21, 2014, 10:15 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18379/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 10:15 p.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-390
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit c48278065c8f119fe92aba1613936c362d470299
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Fri Feb 21 14:13:21 2014 -0800
>
> [HELIX-390] Force message handler registration even when ZK connection state is flaky
>
> :100644 100644 da266f9... 42c4f11... M helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java
> :100644 100644 56e4be8... 425b2da... M helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java
> :100644 100644 422d35e... b7cb3cb... M helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java da266f9
> helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixParticipant.java 56e4be8
> helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java 422d35e
>
> Diff: https://reviews.apache.org/r/18379/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>