You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/12/05 19:42:22 UTC

[GitHub] graceguo-supercat commented on issue #4003: Call props.onChange only when closing filter

graceguo-supercat commented on issue #4003: Call props.onChange only when closing filter
URL: https://github.com/apache/incubator-superset/pull/4003#issuecomment-349418142
 
 
   @betodealmeida Your code change has a problem: 'this.onChange' is undefined but still in use. Though there is no exception thrown, because `this.onChanged` is used as callback for `setState`, it's not a good practice to call undefined function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services