You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/17 02:20:21 UTC
[GitHub] [airflow] mik-laj opened a new pull request #13127: Improve compatibility with google-cloud-pubsub>=2.0.0
mik-laj opened a new pull request #13127:
URL: https://github.com/apache/airflow/pull/13127
Part of: https://github.com/apache/airflow/issues/12116
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13127: Improve compatibility with google-cloud-pubsub>=2.0.0
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13127:
URL: https://github.com/apache/airflow/pull/13127#discussion_r546855124
##########
File path: setup.py
##########
@@ -266,7 +266,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'google-cloud-memcache>=0.2.0',
'google-cloud-monitoring>=0.34.0,<2.0.0',
'google-cloud-os-login>=2.0.0,<3.0.0',
- 'google-cloud-pubsub>=1.0.0,<2.0.0',
+ 'google-cloud-pubsub>=2.0.0,<3.0.0',
Review comment:
Should we change those two lines to `~2.0` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13127: Improve compatibility with google-cloud-pubsub>=2.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13127:
URL: https://github.com/apache/airflow/pull/13127#discussion_r547238996
##########
File path: setup.py
##########
@@ -266,7 +266,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'google-cloud-memcache>=0.2.0',
'google-cloud-monitoring>=0.34.0,<2.0.0',
'google-cloud-os-login>=2.0.0,<3.0.0',
- 'google-cloud-pubsub>=1.0.0,<2.0.0',
+ 'google-cloud-pubsub>=2.0.0,<3.0.0',
Review comment:
How will it benefit us? In the remaining lines, I have one convention and I think it's worth keeping one style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #13127: Improve compatibility with google-cloud-pubsub>=2.0.0
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13127:
URL: https://github.com/apache/airflow/pull/13127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13127: Improve compatibility with google-cloud-pubsub>=2.0.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13127:
URL: https://github.com/apache/airflow/pull/13127#issuecomment-747484850
[The Workflow run](https://github.com/apache/airflow/actions/runs/428336033) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13127: Improve compatibility with google-cloud-pubsub>=2.0.0
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13127:
URL: https://github.com/apache/airflow/pull/13127#discussion_r546855124
##########
File path: setup.py
##########
@@ -266,7 +266,7 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'google-cloud-memcache>=0.2.0',
'google-cloud-monitoring>=0.34.0,<2.0.0',
'google-cloud-os-login>=2.0.0,<3.0.0',
- 'google-cloud-pubsub>=1.0.0,<2.0.0',
+ 'google-cloud-pubsub>=2.0.0,<3.0.0',
Review comment:
Should we change those two lines above to `~2.0` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13127: Improve compatibility with google-cloud-pubsub>=2.0.0
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13127:
URL: https://github.com/apache/airflow/pull/13127#issuecomment-747334932
Static checks failing :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] TobKed commented on a change in pull request #13127: Improve compatibility with google-cloud-pubsub>=2.0.0
Posted by GitBox <gi...@apache.org>.
TobKed commented on a change in pull request #13127:
URL: https://github.com/apache/airflow/pull/13127#discussion_r544959374
##########
File path: airflow/providers/google/cloud/hooks/pubsub.py
##########
@@ -50,7 +50,7 @@ class PubSubHook(GoogleBaseHook):
Hook for accessing Google Pub/Sub.
The Google Cloud project against which actions are applied is determined by
- the project embedded in the Connection referenced by gcp_conn_id.
+ the project embedded in the Connection referencqed by gcp_conn_id.
Review comment:
typo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13127: Improve compatibility with google-cloud-pubsub>=2.0.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13127:
URL: https://github.com/apache/airflow/pull/13127#issuecomment-747426875
[The Workflow run](https://github.com/apache/airflow/actions/runs/428109224) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13127: Improve compatibility with google-cloud-pubsub>=2.0.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13127:
URL: https://github.com/apache/airflow/pull/13127#issuecomment-749124408
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org