[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4536: ARTEMIS-4346: move stomp test client to artemis-test-support module

["gemmellr (via GitHub)" <gi...@apache.org>]

gemmellr commented on code in PR #4536:
URL: https://github.com/apache/activemq-artemis/pull/4536#discussion_r1253189512


##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/tests/integration/stomp/util/AbstractStompClientConnection.java:
##########
@@ -91,8 +90,6 @@ public AbstractStompClientConnection(URI uri) throws Exception {
       transport.setTransportListener(new StompTransportListener());
       transport.connect();
 
-      Wait.waitFor(() -> transport.isConnected(), 1000);

Review Comment:
   I could have replaced this with the [parent] Wait class from artemis-unit-test-support, but since the transport connect is actually synchronous it didnt seem needed and I removed it instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org