[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #4500: Fix static topic test

[GitBox <gi...@apache.org>]

lizhanhui commented on code in PR #4500:
URL: https://github.com/apache/rocketmq/pull/4500#discussion_r905654947


##########
test/src/test/java/org/apache/rocketmq/test/statictopic/StaticTopicIT.java:
##########
@@ -117,7 +116,7 @@ public void testCommandsWithBrokers() throws Exception {
         {
             Set<String> brokers = ImmutableSet.of(broker2Name);
             MQAdminTestUtils.remappingStaticTopicWithCommand(topic, brokers, null, nsAddr);
-            Thread.sleep(500);

Review Comment:
   Fix the magic number, please.



##########
test/src/test/java/org/apache/rocketmq/test/statictopic/StaticTopicIT.java:
##########
@@ -340,7 +340,7 @@ public void testDoubleReadCheckConsumerOffset() throws Exception {
             sendMessagesAndCheck(producer, targetBrokers, topic, queueNum, msgEachQueue, (i + 1) * TopicQueueMappingUtils.DEFAULT_BLOCK_SEQ_SIZE);
         }
 
-        TestUtils.waitForSeconds(20);

Review Comment:
   Same here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org