You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/09/13 17:55:30 UTC

[GitHub] matthiasblaesing commented on issue #872: Relicensed leftover file, excluded cordova testing data

matthiasblaesing commented on issue #872: Relicensed leftover file, excluded cordova testing data
URL: https://github.com/apache/incubator-netbeans/pull/872#issuecomment-421095941
 
 
   Not sure if it helps - I had a look at the unittests - there are three:
   - PlistTest + ProvisioningTest worked before and after your changes
   - IOSPlatformTest fails before and after
   
   `IOSPlatformTest` fail is not related to the XML files, it fails because the whole IOSPlatform code works only on IOs (the libraries as dylibs).
   
   I would merge as is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists