You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tiles.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2010/03/07 15:05:27 UTC
[jira] Created: (TILES-500) "flush" attribute is not evaluated
"flush" attribute is not evaluated
----------------------------------
Key: TILES-500
URL: https://issues.apache.org/jira/browse/TILES-500
Project: Tiles
Issue Type: Bug
Components: tiles-jsp (jsp support)
Affects Versions: 2.2.1, 2.2.0
Reporter: Antonio Petrelli
Fix For: 2.2.2
The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TILES-500) "flush" attribute is not evaluated
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850668#action_12850668 ]
Antonio Petrelli commented on TILES-500:
----------------------------------------
Sorry, I did not notice that you flush the buffer *before* rendering.
The flush must be done *after* calling "end" methods.
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TILES-500) "flush" attribute is not evaluated
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851889#action_12851889 ]
Antonio Petrelli commented on TILES-500:
----------------------------------------
Do you mean TILES-192? It's already connected as a referenced issue.
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TILES-500) "flush" attribute is not evaluated
Posted by "Mck SembWever (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851775#action_12851775 ]
Mck SembWever commented on TILES-500:
-------------------------------------
> I don't know why, I don't think it is useful at all, why should one flush *before* something is inserted?
It doesn't make sense to me either.
You have no idea what currently is in the buffer, but
- you would want to flush what about to be inserted,
- you would want to know you're left with an empty buffer.
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TILES-500) "flush" attribute is not evaluated
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851761#action_12851761 ]
Antonio Petrelli commented on TILES-500:
----------------------------------------
Ok that's fantastic :-D
Curious as I am, I've taken a look at how Tiles 1 worked:
http://svn.eu.apache.org/repos/asf/struts/struts1/trunk/tiles/src/main/java/org/apache/struts/tiles/taglib/InsertTag.java
In fact in Tiles 1 the flush is used to flush *before* the item is inserted. I don't know why, I don't think it is useful at all, why should one flush *before* something is inserted?
However, I think that your final patch is OK, I will apply it ASAP. Thank you!
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TILES-500) "flush" attribute is not evaluated
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850663#action_12850663 ]
Antonio Petrelli commented on TILES-500:
----------------------------------------
The patch is perfect, thanks! I will apply it ASAP.
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-500) "flush" attribute is not evaluated
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-500:
-----------------------------------
Assignee: Antonio Petrelli
Remaining Estimate: 0h
Original Estimate: 0h
Applied patch by Mck SembWever.
Thanks Mck!
Fixed some JSP docs, and added the flush attribute in <tiles:getAsString>
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TILES-500) "flush" attribute is not evaluated
Posted by "Greg Reddin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851935#action_12851935 ]
Greg Reddin commented on TILES-500:
-----------------------------------
@Antonio, no it was way older than that. The issue is probably somewhere in the Struts project. The reporter posted a small webapp that had a crazy recursive tile insert thing going on IIRC.
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TILES-500) "flush" attribute is not evaluated
Posted by "Mck SembWever (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851373#action_12851373 ]
Mck SembWever commented on TILES-500:
-------------------------------------
i only followed the documentation which says :
... If <code>true</code>, current page out stream is flushed before insertion.
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TILES-500) "flush" attribute is not evaluated
Posted by "Greg Reddin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851884#action_12851884 ]
Greg Reddin commented on TILES-500:
-----------------------------------
I'm sorry I don't remember the specifics, but I remember helping someone with a specific bug in Struts-Tiles a *long* time ago where this was an issue. Seems like I was helping with a ticket where somebody was trying to insert a bunch of nested tiles and the flush (or lack of flush) was causing them to render in the wrong order or something. I'll see if there's any chance I can find the ticket.
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-500) "flush" attribute is not evaluated
Posted by "Mck SembWever (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mck SembWever updated TILES-500:
--------------------------------
Attachment: TILES-500.patch
sure thing. flush after insertion, and documentation accordingly.
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch, TILES-500.patch
>
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TILES-500) "flush" attribute is not evaluated
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851382#action_12851382 ]
Antonio Petrelli commented on TILES-500:
----------------------------------------
Sometimes I have to read the documentation... :-D
You're right, but also the documentation is wrong, I don't know what I was thinking at the time :-D
See how it worked in Tiles 2.1.x:
http://tiles.apache.org/2.1/framework/tiles-jsp/xref/org/apache/tiles/jsp/taglib/RenderTag.html#218
Can you patch the documentation too, please?
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-500) "flush" attribute is not evaluated
Posted by "Mck SembWever (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mck SembWever updated TILES-500:
--------------------------------
Attachment: TILES-500.patch
Not entirely understanding what the desired fix here.
But this patch makes flush="true" work as each Tag documents it to.
That is with flush="true" the following code
jspContext.getOut().flush()
is called before any of the Tags do anything.
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TILES-500) "flush" attribute is not evaluated
Posted by "Mck SembWever (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mck SembWever updated TILES-500:
--------------------------------
Attachment: (was: TILES-500.patch)
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TILES-500) "flush" attribute is not evaluated
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli closed TILES-500.
----------------------------------
Resolution: Fixed
> "flush" attribute is not evaluated
> ----------------------------------
>
> Key: TILES-500
> URL: https://issues.apache.org/jira/browse/TILES-500
> Project: Tiles
> Issue Type: Bug
> Components: tiles-jsp (jsp support)
> Affects Versions: 2.2.0, 2.2.1
> Reporter: Antonio Petrelli
> Assignee: Antonio Petrelli
> Fix For: 2.2.2
>
> Attachments: TILES-500.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> The "flush" attribute is not evaluated at all. It is never used in any of the tags that define it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.