You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/06/01 09:32:14 UTC
[GitHub] [mynewt-nimble] Wth-Esp opened a new issue #983: Suggest change the name of function `ble_gattc_notify` and `ble_gattc_notify_custom` into `ble_gatts_notify`and `ble_gatts_notify_custom`
Wth-Esp opened a new issue #983:
URL: https://github.com/apache/mynewt-nimble/issues/983
Notify procedure can only be operated by GATT Server.
So, I think the ble_gattc_notify is not a proper name for notify, it makes me confuse when I call this function to customize a notify from server to client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc edited a comment on issue #983: Suggest change the name of function `ble_gattc_notify` and `ble_gattc_notify_custom` into `ble_gatts_notify`and `ble_gatts_notify_custom`
Posted by GitBox <gi...@apache.org>.
sjanc edited a comment on issue #983:
URL: https://github.com/apache/mynewt-nimble/issues/983#issuecomment-852908520
yes, this is currently named like that for historical reasons :) but I'm totally fine with adding wrappers with fixed names and marking old ones as deprecated. Would you like to send such PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] Wth-Esp commented on issue #983: Suggest change the name of function `ble_gattc_notify` and `ble_gattc_notify_custom` into `ble_gatts_notify`and `ble_gatts_notify_custom`
Posted by GitBox <gi...@apache.org>.
Wth-Esp commented on issue #983:
URL: https://github.com/apache/mynewt-nimble/issues/983#issuecomment-853069174
@sjanc Yes, I'm willing to do this. Please wait for my updates, maybe I will change other mistakes by the way. When the PR is ready, I will close this issue, thanks for your quick reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on issue #983: Suggest change the name of function `ble_gattc_notify` and `ble_gattc_notify_custom` into `ble_gatts_notify`and `ble_gatts_notify_custom`
Posted by GitBox <gi...@apache.org>.
sjanc commented on issue #983:
URL: https://github.com/apache/mynewt-nimble/issues/983#issuecomment-852908520
yes, this is currently for historical reasons :) but I'm totally fine with adding wrappers with fixed names and marking old ones as deprecated. Would you like to send such PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org