You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/30 05:25:50 UTC
[GitHub] [spark] c21 opened a new pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
c21 opened a new pull request #30200:
URL: https://github.com/apache/spark/pull/30200
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
As a followup comment from https://github.com/apache/spark/pull/29804#issuecomment-700650620 , here we add add the physical plan rule DisableUnnecessaryBucketedScan into AQE AdaptiveSparkPlanExec.queryStagePreparationRules, to make auto bucketed scan work with AQE.
The change is mostly in:
* `AdaptiveSparkPlanExec.scala`: add physical plan rule `DisableUnnecessaryBucketedScan`
* `DisableUnnecessaryBucketedScan.scala`: propagate logical plan link for the file source scan exec operator, otherwise we lose the logical plan link information when AQE is enabled, and will get exception [here](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala#L176). (for example, for query `SELECT * FROM bucketed_table` with AQE is enabled)
* `DisableUnnecessaryBucketedScanSuite.scala`: add new test suite for AQE enabled - `DisableUnnecessaryBucketedScanWithoutHiveSupportSuiteAE`, and changed some of tests to use `AdaptiveSparkPlanHelper.find/collect`, to make the plan verification work when AQE enabled.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
It's reasonable to add the support to allow disabling unnecessary bucketed scan with AQE is enabled, this helps optimize the query when AQE is enabled.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added unit test in `DisableUnnecessaryBucketedScanSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719283073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719379577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719324402
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719323855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30200:
URL: https://github.com/apache/spark/pull/30200#discussion_r514891961
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -85,14 +86,16 @@ case class AdaptiveSparkPlanExec(
@transient private val removeRedundantProjects = RemoveRedundantProjects
@transient private val removeRedundantSorts = RemoveRedundantSorts
@transient private val ensureRequirements = EnsureRequirements
+ @transient private val disableUnnecessaryBucketedScan = DisableUnnecessaryBucketedScan
// A list of physical plan rules to be applied before creation of query stages. The physical
// plan should reach a final status of query stages (i.e., no more addition or removal of
// Exchange nodes) after running these rules.
private def queryStagePreparationRules: Seq[Rule[SparkPlan]] = Seq(
removeRedundantProjects,
removeRedundantSorts,
- ensureRequirements
+ ensureRequirements,
+ disableUnnecessaryBucketedScan
Review comment:
seems we can just put `DisableUnnecessaryBucketedScan`, same to other rules.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -85,14 +86,16 @@ case class AdaptiveSparkPlanExec(
@transient private val removeRedundantProjects = RemoveRedundantProjects
@transient private val removeRedundantSorts = RemoveRedundantSorts
@transient private val ensureRequirements = EnsureRequirements
+ @transient private val disableUnnecessaryBucketedScan = DisableUnnecessaryBucketedScan
// A list of physical plan rules to be applied before creation of query stages. The physical
// plan should reach a final status of query stages (i.e., no more addition or removal of
// Exchange nodes) after running these rules.
private def queryStagePreparationRules: Seq[Rule[SparkPlan]] = Seq(
removeRedundantProjects,
removeRedundantSorts,
- ensureRequirements
+ ensureRequirements,
+ disableUnnecessaryBucketedScan
Review comment:
seems we can just put `DisableUnnecessaryBucketedScan`. Same to other rules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719326042
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719379506
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35050/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719255242
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35045/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719282990
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35045/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #30200:
URL: https://github.com/apache/spark/pull/30200#discussion_r514898262
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -85,14 +86,16 @@ case class AdaptiveSparkPlanExec(
@transient private val removeRedundantProjects = RemoveRedundantProjects
@transient private val removeRedundantSorts = RemoveRedundantSorts
@transient private val ensureRequirements = EnsureRequirements
+ @transient private val disableUnnecessaryBucketedScan = DisableUnnecessaryBucketedScan
// A list of physical plan rules to be applied before creation of query stages. The physical
// plan should reach a final status of query stages (i.e., no more addition or removal of
// Exchange nodes) after running these rules.
private def queryStagePreparationRules: Seq[Rule[SparkPlan]] = Seq(
removeRedundantProjects,
removeRedundantSorts,
- ensureRequirements
+ ensureRequirements,
+ disableUnnecessaryBucketedScan
Review comment:
@cloud-fan - agree, updated.
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/sources/DisableUnnecessaryBucketedScanSuite.scala
##########
@@ -230,14 +248,14 @@ abstract class DisableUnnecessaryBucketedScanSuite extends QueryTest with SQLTes
assertCached(spark.table("t1"))
// Verify cached bucketed table scan not disabled
- val partitioning = spark.table("t1").queryExecution.executedPlan
- .outputPartitioning
- assert(partitioning match {
+ val inMemoryScan = find(spark.table("t1").queryExecution.executedPlan)(
Review comment:
@cloud-fan - sure, it's less verbose, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719425303
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35052/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30200:
URL: https://github.com/apache/spark/pull/30200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719405538
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35052/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719196882
cc @cloud-fan if you have time to take a look, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719425332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-720299873
Thank you @cloud-fan for review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30200:
URL: https://github.com/apache/spark/pull/30200#discussion_r514894214
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/sources/DisableUnnecessaryBucketedScanSuite.scala
##########
@@ -230,14 +248,14 @@ abstract class DisableUnnecessaryBucketedScanSuite extends QueryTest with SQLTes
assertCached(spark.table("t1"))
// Verify cached bucketed table scan not disabled
- val partitioning = spark.table("t1").queryExecution.executedPlan
- .outputPartitioning
- assert(partitioning match {
+ val inMemoryScan = find(spark.table("t1").queryExecution.executedPlan)(
Review comment:
how about `stripAQEPlan(spark.table("t1").queryExecution.executedPlan).outputPartitioning`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719316237
**[Test build #130445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130445/testReport)** for PR 30200 at commit [`36815fc`](https://github.com/apache/spark/commit/36815fc2d7ef1f436db3fc26b3dffa924d5b65ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719200765
**[Test build #130440 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130440/testReport)** for PR 30200 at commit [`f721855`](https://github.com/apache/spark/commit/f7218559f359effbb59be643623bfc199c9a81e4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719283073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719324714
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719425332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719324732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130440/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719324402
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719316237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-720272405
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719347782
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35050/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719329172
**[Test build #130447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130447/testReport)** for PR 30200 at commit [`36815fc`](https://github.com/apache/spark/commit/36815fc2d7ef1f436db3fc26b3dffa924d5b65ae).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30200: [SPARK-33027][SQL] Add DisableUnnecessaryBucketedScan rule to AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30200:
URL: https://github.com/apache/spark/pull/30200#issuecomment-719379577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org