You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/01/28 16:51:52 UTC
[GitHub] [doris] morningman opened a new pull request, #16175: [docker](iceberg) add iceberg docker compose and modify scripts
morningman opened a new pull request, #16175:
URL: https://github.com/apache/doris/pull/16175
# Proposed changes
Issue Number: close #xxx
## Problem summary
1. Add iceberg docker compose
2. Rename start-thirdparties-docker.sh to run-thirdparties-docker.sh and support start to stop specified components.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
4. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
6. Does it need to update dependencies:
- [ ] Yes
- [ ] No
7. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts
Posted by github-actions.
github-actions[bot] commented on PR #16175:
URL: https://github.com/apache/doris/pull/16175#issuecomment-1407440274
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4032736366") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In docker/thirdparties/custom_settings.sh line 23:
CONTAINER_UID="doris--"
^-----------^ SC2034 (warning): CONTAINER_UID appears unused. Verify use (or export if used externally).
In docker/thirdparties/run-thirdparties-docker.sh line 116:
COMPONENTS=$(echo "${COMPONENTS}" | sed 's/ //g')
^-- SC2001 (style): See if you can use ${variable//search/replace} instead.
In docker/thirdparties/run-thirdparties-docker.sh line 121:
COMPONENTS_ARR=(${COMPONENTS//,/ })
^----------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
For more information:
https://www.shellcheck.net/wiki/SC2034 -- CONTAINER_UID appears unused. Ver...
https://www.shellcheck.net/wiki/SC2206 -- Quote to prevent word splitting/g...
https://www.shellcheck.net/wiki/SC2001 -- See if you can use ${variable//se...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #16175:
URL: https://github.com/apache/doris/pull/16175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts
Posted by github-actions.
github-actions[bot] commented on PR #16175:
URL: https://github.com/apache/doris/pull/16175#issuecomment-1407443853
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4032812188") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In docker/thirdparties/run-thirdparties-docker.sh line 120:
COMPONENTS_ARR=(${COMPONENTS//,/ })
^----------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
In docker/thirdparties/run-thirdparties-docker.sh line 129:
for element in ${COMPONENTS_ARR[@]}; do
^------------------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements.
For more information:
https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
https://www.shellcheck.net/wiki/SC2206 -- Quote to prevent word splitting/g...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts
Posted by github-actions.
github-actions[bot] commented on PR #16175:
URL: https://github.com/apache/doris/pull/16175#issuecomment-1407439030
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4032713862") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In docker/thirdparties/custom_settings.sh line 23:
CONTAINER_UID="doris--"
^-----------^ SC2034 (warning): CONTAINER_UID appears unused. Verify use (or export if used externally).
In docker/thirdparties/run-thirdparties-docker.sh line 116:
COMPONENTS=`echo "${COMPONENTS}" | sed 's/ //g'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-- SC2001 (style): See if you can use ${variable//search/replace} instead.
Did you mean:
COMPONENTS=$(echo "${COMPONENTS}" | sed 's/ //g')
In docker/thirdparties/run-thirdparties-docker.sh line 121:
COMPONENTS_ARR=(${COMPONENTS//,/ })
^----------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
In docker/thirdparties/run-thirdparties-docker.sh line 130:
for element in ${COMPONENTS_ARR[@]}; do
^------------------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements.
For more information:
https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
https://www.shellcheck.net/wiki/SC2034 -- CONTAINER_UID appears unused. Ver...
https://www.shellcheck.net/wiki/SC2206 -- Quote to prevent word splitting/g...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- docker/thirdparties/run-thirdparties-docker.sh.orig
+++ docker/thirdparties/run-thirdparties-docker.sh
@@ -113,7 +113,7 @@
exit 1
fi
-COMPONENTS=`echo "${COMPONENTS}" | sed 's/ //g'`
+COMPONENTS=$(echo "${COMPONENTS}" | sed 's/ //g')
echo "Components are: ${COMPONENTS}"
echo "Container UID: ${CONTAINER_UID}"
echo "Stop: ${STOP}"
@@ -131,9 +131,9 @@
if [[ "${element}"x == "mysql"x ]]; then
RUN_MYSQL=1
elif [[ "${element}"x == "pg"x ]]; then
- RUN_PG=1
+ RUN_PG=1
elif [[ "${element}"x == "oracle"x ]]; then
- RUN_ORACLE=1
+ RUN_ORACLE=1
elif [[ "${element}"x == "sqlserver"x ]]; then
RUN_SQLSERVER=1
elif [[ "${element}"x == "es"x ]]; then
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on code in PR #16175:
URL: https://github.com/apache/doris/pull/16175#discussion_r1089855257
##########
docker/thirdparties/run-thirdparties-docker.sh:
##########
@@ -117,7 +117,10 @@ echo "Components are: ${COMPONENTS}"
echo "Container UID: ${CONTAINER_UID}"
echo "Stop: ${STOP}"
-COMPONENTS_ARR=(${COMPONENTS//,/ })
+OLD_IFS="${IFS}"
+IFS=','
+read -r -a COMPONENTS_ARR <<<"${COMPONENTS}"
+IFS="${OLD_IFS}"
Review Comment:
```suggestion
IFS=',' read -r -a COMPONENTS_ARR <<<"${COMPONENTS}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #16175:
URL: https://github.com/apache/doris/pull/16175#discussion_r1089876363
##########
docker/thirdparties/run-thirdparties-docker.sh:
##########
@@ -117,7 +117,10 @@ echo "Components are: ${COMPONENTS}"
echo "Container UID: ${CONTAINER_UID}"
echo "Stop: ${STOP}"
-COMPONENTS_ARR=(${COMPONENTS//,/ })
+OLD_IFS="${IFS}"
+IFS=','
+read -r -a COMPONENTS_ARR <<<"${COMPONENTS}"
+IFS="${OLD_IFS}"
Review Comment:
OK, I will modify it in next PR to save some regression test resource
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts
Posted by github-actions.
github-actions[bot] commented on PR #16175:
URL: https://github.com/apache/doris/pull/16175#issuecomment-1407440187
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4032734118") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In docker/thirdparties/custom_settings.sh line 23:
CONTAINER_UID="doris--"
^-----------^ SC2034 (warning): CONTAINER_UID appears unused. Verify use (or export if used externally).
In docker/thirdparties/run-thirdparties-docker.sh line 116:
COMPONENTS=$(echo "${COMPONENTS}" | sed 's/ //g')
^-- SC2001 (style): See if you can use ${variable//search/replace} instead.
In docker/thirdparties/run-thirdparties-docker.sh line 121:
COMPONENTS_ARR=(${COMPONENTS//,/ })
^----------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
For more information:
https://www.shellcheck.net/wiki/SC2034 -- CONTAINER_UID appears unused. Ver...
https://www.shellcheck.net/wiki/SC2206 -- Quote to prevent word splitting/g...
https://www.shellcheck.net/wiki/SC2001 -- See if you can use ${variable//se...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts
Posted by github-actions.
github-actions[bot] commented on PR #16175:
URL: https://github.com/apache/doris/pull/16175#issuecomment-1407444200
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4032819831") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In docker/thirdparties/run-thirdparties-docker.sh line 120:
COMPONENTS_ARR=(${COMPONENTS//,/ })
^----------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
In docker/thirdparties/run-thirdparties-docker.sh line 129:
for element in ${COMPONENTS_ARR[@]}; do
^------------------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements.
For more information:
https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
https://www.shellcheck.net/wiki/SC2206 -- Quote to prevent word splitting/g...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org