You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "reypader (via GitHub)" <gi...@apache.org> on 2023/07/18 05:33:43 UTC

[GitHub] [incubator-pekko-connectors-samples] reypader opened a new pull request, #12: WIP: Replace AkkaParadoxPlugin with PekkoParadoxPlugin

reypader opened a new pull request, #12:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/12

   Fixes #11 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko-connectors-samples] pjfanning commented on a diff in pull request #12: WIP: Replace AkkaParadoxPlugin with PekkoParadoxPlugin

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #12:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/12#discussion_r1266341118


##########
docs/project/plugins.sbt:
##########
@@ -1,6 +1,7 @@
-addSbtPlugin("com.lightbend.akka" % "sbt-paradox-akka" % "0.44")
+addSbtPlugin("org.apache.pekko" % "pekko-sbt-paradox" % "0.0.0+55-2e9e22a8-SNAPSHOT") // #TODO: user release version

Review Comment:
   you need to copy paste all of this
   
   https://github.com/apache/incubator-pekko/blob/main/project/plugins.sbt#L39-L47



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko-connectors-samples] reypader closed pull request #12: WIP: Replace AkkaParadoxPlugin with PekkoParadoxPlugin

Posted by "reypader (via GitHub)" <gi...@apache.org>.
reypader closed pull request #12: WIP: Replace AkkaParadoxPlugin with PekkoParadoxPlugin
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko-connectors-samples] reypader commented on pull request #12: WIP: Replace AkkaParadoxPlugin with PekkoParadoxPlugin

Posted by "reypader (via GitHub)" <gi...@apache.org>.
reypader commented on PR #12:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/12#issuecomment-1639520771

   Base template applies but subpages lose the pekko logo and the header is blue. Still trying to figure out why


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko-connectors-samples] reypader commented on pull request #12: WIP: Replace AkkaParadoxPlugin with PekkoParadoxPlugin

Posted by "reypader (via GitHub)" <gi...@apache.org>.
reypader commented on PR #12:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/12#issuecomment-1639750127

   @pjfanning thanks for the heads up! I'll close this ticket now. Looking at it upfront, it seemed easy enough 😆 . 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko-connectors-samples] pjfanning commented on pull request #12: WIP: Replace AkkaParadoxPlugin with PekkoParadoxPlugin

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #12:
URL: https://github.com/apache/incubator-pekko-connectors-samples/pull/12#issuecomment-1639680947

   @reypader applying this is actually hard. I didn't raise this and expect you to do it. Someone who has done it before will find this much easier. As well as the plugin.sbt issue I already raised, there are quite a lot of settings in incubator-pekko project/Paradox.scala that need to be copied over - the pekkoThemeSettings and those settings need to be wired into the project settings.
   
   I can have a look at this myself in a few days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org