You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/07/13 09:44:00 UTC
[jira] [Commented] (WICKET-6982) Unnecessary initialization of stateful pages in ListenerRequestHandler
[ https://issues.apache.org/jira/browse/WICKET-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566237#comment-17566237 ]
ASF subversion and git services commented on WICKET-6982:
---------------------------------------------------------
Commit 77634d956e0b78884560ec6391feba5f2e2ab7a1 in wicket's branch refs/heads/wicket-9.x from Thomas Heigl
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=77634d956e ]
WICKET-6982 Rely on conditional logic in `Page.isPageStateless()` instead of forcing initialization for all pages (#526)
(cherry picked from commit d248853305e6a0e4f6e95fac93f56ddceb6a17aa)
> Unnecessary initialization of stateful pages in ListenerRequestHandler
> ----------------------------------------------------------------------
>
> Key: WICKET-6982
> URL: https://issues.apache.org/jira/browse/WICKET-6982
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 9.10.0
> Reporter: Thomas Heigl
> Assignee: Thomas Heigl
> Priority: Major
> Fix For: 9.11.0
>
> Attachments: image-2022-05-16-11-49-09-093.png
>
>
> ListenerRequestHandler currently forces initialization of pages. For already initialized stateful pages, this traverses the entire component hierarchy. For large pages, this can be a costly operation.
> My profiler shows a significant amount of CPU load coming from these unnecessary traversals:
> !image-2022-05-16-11-49-09-093.png|width=427,height=213!
> Forcing page initialization was originally introduced in WICKET-4116 in [this commit|https://github.com/apache/wicket/commit/42a436235ff4ed60f1eaa0f406ea96aa63a6eb2e] to fix an issue with expired pages and checking for statelessness.
> In WICKET-5083, [this commit|https://github.com/apache/wicket/commit/34f43642195058f375d161dbb7cec58b40711423] added the same forced initialization directly to {{{}Page.isPageStateless(){}}}.
> I think we can get rid of the initialization in {{ListenerRequestHandler}} and rely on the conditional logic in {{Page.isPageStateless}} to trigger initialization if necessary.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)