You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/07 03:11:40 UTC

[GitHub] [spark] Yikun commented on a diff in pull request #36476: [SPARK-39121][K8S][DOC] Fix format error on running-on-kubernetes doc

Yikun commented on code in PR #36476:
URL: https://github.com/apache/spark/pull/36476#discussion_r867294317


##########
docs/running-on-kubernetes.md:
##########
@@ -1766,7 +1766,7 @@ To use Volcano as a custom scheduler the user needs to specify the following con
 --conf spark.kubernetes.scheduler.volcano.podGroupTemplateFile=/path/to/podgroup-template.yaml
 # Specify driver/executor VolcanoFeatureStep
 --conf spark.kubernetes.driver.pod.featureSteps=org.apache.spark.deploy.k8s.features.VolcanoFeatureStep
---conf spark.kubernetes.executor.pod.featureSteps=org.apache.spark.deploy.k8s.features.VolcanoFeatureStep```
+--conf spark.kubernetes.executor.pod.featureSteps=org.apache.spark.deploy.k8s.features.VolcanoFeatureStep

Review Comment:
   Before:
   ![image](https://user-images.githubusercontent.com/1736354/167235623-9f10712b-c68f-4179-a3da-29b73069ac15.png)
   
   After:
   ![image](https://user-images.githubusercontent.com/1736354/167235631-3d5c8252-0f41-455a-ac63-979977ad15ee.png)
   



##########
docs/running-on-kubernetes.md:
##########
@@ -1729,8 +1729,8 @@ Spark allows users to specify a custom Kubernetes schedulers.
 3. Specify scheduler feature step.
 
    Users may also consider to use <code>spark.kubernetes.{driver/executor}.pod.featureSteps</code> to support more complex requirements, including but not limited to:
-  - Create additional Kubernetes custom resources for driver/executor scheduling.
-  - Set scheduler hints according to configuration or existing Pod info dynamically.
+   - Create additional Kubernetes custom resources for driver/executor scheduling.
+   - Set scheduler hints according to configuration or existing Pod info dynamically.

Review Comment:
   Before:
   ![image](https://user-images.githubusercontent.com/1736354/167235581-7b3261ba-4a34-4c04-b98d-5c5594a45147.png)
   
   After:
   ![image](https://user-images.githubusercontent.com/1736354/167235595-cb67572c-b0b3-4fea-bd8a-d1745148999d.png)
   



##########
docs/running-on-kubernetes.md:
##########
@@ -1699,7 +1699,7 @@ Kubernetes supports [Pod priority](https://kubernetes.io/docs/concepts/schedulin
 
 Spark on Kubernetes allows defining the priority of jobs by [Pod template](#pod-template). The user can specify the <code>priorityClassName</code> in driver or executor Pod template <code>spec</code> section. Below is an example to show how to specify it:
 
-```
+```yaml

Review Comment:
   Before:
   ![image](https://user-images.githubusercontent.com/1736354/167235612-7d4ac29d-44b1-4841-81a4-5eab9d2c9999.png)
   
   After:
   ![image](https://user-images.githubusercontent.com/1736354/167235616-75e92cb2-ff78-4042-b847-75deaba98fd8.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org