You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/18 01:40:29 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2561: tools: Fix version.sh

masayuki2009 opened a new pull request #2561:
URL: https://github.com/apache/incubator-nuttx/pull/2561


   ## Summary
   
   - The latest version.sh retrieves version information from git tag
   - However, if a repository contains private tags, it will fail
   - This commit fixes this issue
   - See https://github.com/apache/incubator-nuttx/pull/2557
   
   ## Impact
   
   - version.sh only
   
   ## Testing
   
   - Tested with https://github.com/masayuki2009/incubator-nuttx
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] anchao commented on pull request #2561: tools: Fix version.sh

Posted by GitBox <gi...@apache.org>.
anchao commented on pull request #2561:
URL: https://github.com/apache/incubator-nuttx/pull/2561#issuecomment-747833895


   The processing here will be messy if create a tag with a similar name locally(e.g nuttx-******), 
   Seems that more precise regular expression matching is needed here, I have verified this patch which works as expected.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2561: tools: Fix version.sh

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2561:
URL: https://github.com/apache/incubator-nuttx/pull/2561


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org