You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/04/11 01:44:08 UTC

[kudu-CR] [mini-sentry] increase timeout for Sentry startup

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12990


Change subject: [mini-sentry] increase timeout for Sentry startup
......................................................................

[mini-sentry] increase timeout for Sentry startup

This patch increases timeout for Sentry startup time from 60 to 120
seconds.  The motivation for this change is spotting flakiness of
some tests from sentry_authz_provider-test where Sentry's JVM was
killed with SIGQUIT (generating a core), and also spotting messages
like below for the tests that hasn't failed:

W0410 23:19:17.437450  7615 mini_sentry.cc:85] Time spent Starting Sentry: real 47.459s	user 0.002s	sys 0.033s
W0410 23:20:30.217487  7615 mini_sentry.cc:85] Time spent Starting Sentry: real 60.443s	user 0.000s	sys 0.042s
W0410 23:21:42.836758  7615 mini_sentry.cc:85] Time spent Starting Sentry: real 60.369s	user 0.002s	sys 0.042s
W0410 23:22:37.729540  7615 mini_sentry.cc:85] Time spent Starting Sentry: real 52.703s	user 0.000s	sys 0.035s
W0410 23:19:26.633388 32082 mini_sentry.cc:85] Time spent Starting Sentry: real 62.565s	user 0.002s	sys 0.048s
W0410 23:20:13.020031 32082 mini_sentry.cc:85] Time spent Starting Sentry: real 44.958s	user 0.008s	sys 0.030s
W0410 23:21:08.531953 32082 mini_sentry.cc:85] Time spent Starting Sentry: real 47.127s	user 0.001s	sys 0.038s
W0410 23:22:18.332482 32082 mini_sentry.cc:85] Time spent Starting Sentry: real 58.223s	user 0.000s	sys 0.043s

Change-Id: I555fb017087c6804c47a0c4bcc40d3ae0ee6006f
---
M src/kudu/sentry/mini_sentry.cc
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/12990/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I555fb017087c6804c47a0c4bcc40d3ae0ee6006f
Gerrit-Change-Number: 12990
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [mini-sentry] increase timeout for Sentry startup

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12990 )

Change subject: [mini-sentry] increase timeout for Sentry startup
......................................................................

[mini-sentry] increase timeout for Sentry startup

This patch increases timeout for Sentry startup time from 60 to 120
seconds.  The motivation for this change is spotting flakiness of
some tests from sentry_authz_provider-test where Sentry's JVM was
killed with SIGQUIT (generating a core), and also spotting messages
like below for the tests that hasn't failed:

W0410 23:19:17.437450  7615 mini_sentry.cc:85] Time spent Starting Sentry: real 47.459s	user 0.002s	sys 0.033s
W0410 23:20:30.217487  7615 mini_sentry.cc:85] Time spent Starting Sentry: real 60.443s	user 0.000s	sys 0.042s
W0410 23:21:42.836758  7615 mini_sentry.cc:85] Time spent Starting Sentry: real 60.369s	user 0.002s	sys 0.042s
W0410 23:22:37.729540  7615 mini_sentry.cc:85] Time spent Starting Sentry: real 52.703s	user 0.000s	sys 0.035s
W0410 23:19:26.633388 32082 mini_sentry.cc:85] Time spent Starting Sentry: real 62.565s	user 0.002s	sys 0.048s
W0410 23:20:13.020031 32082 mini_sentry.cc:85] Time spent Starting Sentry: real 44.958s	user 0.008s	sys 0.030s
W0410 23:21:08.531953 32082 mini_sentry.cc:85] Time spent Starting Sentry: real 47.127s	user 0.001s	sys 0.038s
W0410 23:22:18.332482 32082 mini_sentry.cc:85] Time spent Starting Sentry: real 58.223s	user 0.000s	sys 0.043s

Change-Id: I555fb017087c6804c47a0c4bcc40d3ae0ee6006f
Reviewed-on: http://gerrit.cloudera.org:8080/12990
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/sentry/mini_sentry.cc
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I555fb017087c6804c47a0c4bcc40d3ae0ee6006f
Gerrit-Change-Number: 12990
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [mini-sentry] increase timeout for Sentry startup

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12990 )

Change subject: [mini-sentry] increase timeout for Sentry startup
......................................................................


Patch Set 1: Code-Review+2

Interesting, I wonder if Hao has any insight into why it might be taking so long.


-- 
To view, visit http://gerrit.cloudera.org:8080/12990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I555fb017087c6804c47a0c4bcc40d3ae0ee6006f
Gerrit-Change-Number: 12990
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 11 Apr 2019 02:26:24 +0000
Gerrit-HasComments: No