You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/10 11:18:59 UTC

[GitHub] [flink] godfreyhe opened a new pull request #8677: [FLINK-12795] [table-planner-blink] Extracted creation & configuration of FrameworkConfig & RelBuilder to separate class in blink planner

godfreyhe opened a new pull request #8677: [FLINK-12795] [table-planner-blink] Extracted creation & configuration of FrameworkConfig & RelBuilder to separate class in blink planner
URL: https://github.com/apache/flink/pull/8677
 
 
   
   
   ## What is the purpose of the change
   
   *Extracted creation & configuration of FrameworkConfig & RelBuilder to separate class in blink planner. 
   Both those classes should be configured for a single planning session.
   They are constructed of static properties, that do not change in a
   lifecycle of TableEnvironment(e.g. TypeSystem) & dynamic (e.g. default
   path). The newly introduced PlanningConfigurationBuilder class helps to split
   those two sets of properties.*
   
   
   ## Brief change log
   
     - *Extracted creation & configuration of FrameworkConfig & RelBuilder logic into PlanningConfigurationBuilder, and make sure that FrameworkConfig & RelBuilder meet static and dynamic properties as mentioned above*
   
   
   ## Verifying this change
   
   
   This change is already covered by existing tests*.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services