You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/02 02:16:32 UTC
[GitHub] [incubator-tvm] areusch opened a new pull request #6378: acquire gil while finalizing PackedFunc
areusch opened a new pull request #6378:
URL: https://github.com/apache/incubator-tvm/pull/6378
looks like we were not acquiring the GIL before Py_DECREF, this is causing one of my µTVM RPC server test cases to crash when using cython FFI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6378: acquire gil while finalizing PackedFunc
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6378:
URL: https://github.com/apache/incubator-tvm/pull/6378#issuecomment-685243802
cc @jroesch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6378: acquire gil while finalizing PackedFunc
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6378:
URL: https://github.com/apache/incubator-tvm/pull/6378
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6378: acquire gil while finalizing PackedFunc
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6378:
URL: https://github.com/apache/incubator-tvm/pull/6378#issuecomment-685306747
It is interesting finding! Didn’t notice GIL is not acquired in tvm_callback_finalize...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org