You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ia...@apache.org on 2014/04/23 20:57:30 UTC

[10/17] git commit: CB-6402 [WP8] pass empty string instead of null for [optional] windowFeatures string

CB-6402 [WP8] pass empty string instead of null for [optional] windowFeatures string


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/commit/bddf86c3
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/tree/bddf86c3
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/diff/bddf86c3

Branch: refs/heads/master
Commit: bddf86c3cefd9d787876d15e771beb499e43eb2f
Parents: 25f306d
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Wed Apr 9 12:26:47 2014 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Wed Apr 9 12:26:47 2014 -0700

----------------------------------------------------------------------
 www/inappbrowser.js | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-inappbrowser/blob/bddf86c3/www/inappbrowser.js
----------------------------------------------------------------------
diff --git a/www/inappbrowser.js b/www/inappbrowser.js
index ebcfa24..3535b6f 100644
--- a/www/inappbrowser.js
+++ b/www/inappbrowser.js
@@ -90,6 +90,8 @@ module.exports = function(strUrl, strWindowName, strWindowFeatures) {
        iab._eventHandler(eventname);
     };
 
+    strWindowFeatures = strWindowFeatures || "";
+
     exec(cb, cb, "InAppBrowser", "open", [strUrl, strWindowName, strWindowFeatures]);
     return iab;
 };