You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vineet Garg <vg...@hortonworks.com> on 2017/10/02 18:11:22 UTC

Review Request 62728: Fix for Explain plan not working

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62728/
-----------------------------------------------------------

Review request for hive and Jesús Camacho Rodríguez.


Bugs: HIVE-17602
    https://issues.apache.org/jira/browse/HIVE-17602


Repository: hive-git


Description
-------

Inadvertently broken by HIVE-17510


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java da76c3ca28 


Diff: https://reviews.apache.org/r/62728/diff/1/


Testing
-------


Thanks,

Vineet Garg

Re: Review Request 62728: Fix for Explain plan not working

Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62728/#review186895
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java
Line 893 (original), 893 (patched)
<https://reviews.apache.org/r/62728/#comment263772>

    Semantics of fix are correct.
    
    However, could it be rewritten this more compact version:
    
    ...
    if (postProcess(xpl_note)) {
      val = m.invoke(work, inTest);
    } else
    ...


- Jesús Camacho Rodríguez


On Oct. 2, 2017, 6:11 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62728/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2017, 6:11 p.m.)
> 
> 
> Review request for hive and Jesús Camacho Rodríguez.
> 
> 
> Bugs: HIVE-17602
>     https://issues.apache.org/jira/browse/HIVE-17602
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Inadvertently broken by HIVE-17510
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java da76c3ca28 
> 
> 
> Diff: https://reviews.apache.org/r/62728/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

Re: Review Request 62728: Fix for Explain plan not working

Posted by Vineet Garg <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62728/
-----------------------------------------------------------

(Updated Oct. 3, 2017, 3 a.m.)


Review request for hive and Jesús Camacho Rodríguez.


Changes
-------

Addressed review comments


Bugs: HIVE-17602
    https://issues.apache.org/jira/browse/HIVE-17602


Repository: hive-git


Description
-------

Inadvertently broken by HIVE-17510


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java da76c3ca28 


Diff: https://reviews.apache.org/r/62728/diff/2/

Changes: https://reviews.apache.org/r/62728/diff/1-2/


Testing
-------


Thanks,

Vineet Garg