You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2015/11/26 06:42:15 UTC
[GitHub] tajo pull request: TAJO-1990: Refine some parts in HBaseTablespace...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/880
TAJO-1990: Refine some parts in HBaseTablespace.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1990
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/880.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #880
----
commit 367dcbc3162c42f2eddec8d544ac246150760220
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-11-26T05:41:46Z
TAJO-1990: Refine some parts in HBaseTablespace.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1990: Refine some parts in HBaseTablespace...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/880#issuecomment-161533934
Rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1990: Refine some parts in HBaseTablespace...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/880#discussion_r47455815
--- Diff: tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java ---
@@ -702,25 +705,22 @@ public String toString() {
@Nullable EvalNode filterCondition)
throws IOException, MissingTablePropertyException, InvalidTablePropertyException {
- List<IndexPredication> indexPredications = new ArrayList<>();
- Column[] indexableColumns = getIndexableColumns(tableDesc);
- if (indexableColumns != null && indexableColumns.length == 1) {
- // Currently supports only single index column.
- List<Set<EvalNode>> indexablePredicateList = findIndexablePredicateSet(filterCondition, indexableColumns);
- for (Set<EvalNode> eachEvalSet: indexablePredicateList) {
- Pair<Datum, Datum> indexPredicationValues = getIndexablePredicateValue(columnMapping, eachEvalSet);
- if (indexPredicationValues != null) {
- IndexPredication indexPredication = new IndexPredication();
- indexPredication.setColumn(indexableColumns[0]);
- indexPredication.setColumnId(tableDesc.getLogicalSchema().getColumnId(indexableColumns[0].getQualifiedName()));
- indexPredication.setStartValue(indexPredicationValues.getFirst());
- indexPredication.setStopValue(indexPredicationValues.getSecond());
-
- indexPredications.add(indexPredication);
- }
- }
+ final Column[] indexableColumns = getIndexableColumns(tableDesc);
+ if (indexableColumns == null && indexableColumns.length == 0) {
--- End diff --
```&&``` needs to be ```||```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1990: Refine some parts in HBaseTablespace...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/880#issuecomment-164311282
Fixed the test failure and rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1990: Refine some parts in HBaseTablespace...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/880#issuecomment-164321006
+1 this patch looks good to me.
Please fix the above condition before commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1990: Refine some parts in HBaseTablespace...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/880#discussion_r47464263
--- Diff: tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java ---
@@ -702,25 +705,22 @@ public String toString() {
@Nullable EvalNode filterCondition)
throws IOException, MissingTablePropertyException, InvalidTablePropertyException {
- List<IndexPredication> indexPredications = new ArrayList<>();
- Column[] indexableColumns = getIndexableColumns(tableDesc);
- if (indexableColumns != null && indexableColumns.length == 1) {
- // Currently supports only single index column.
- List<Set<EvalNode>> indexablePredicateList = findIndexablePredicateSet(filterCondition, indexableColumns);
- for (Set<EvalNode> eachEvalSet: indexablePredicateList) {
- Pair<Datum, Datum> indexPredicationValues = getIndexablePredicateValue(columnMapping, eachEvalSet);
- if (indexPredicationValues != null) {
- IndexPredication indexPredication = new IndexPredication();
- indexPredication.setColumn(indexableColumns[0]);
- indexPredication.setColumnId(tableDesc.getLogicalSchema().getColumnId(indexableColumns[0].getQualifiedName()));
- indexPredication.setStartValue(indexPredicationValues.getFirst());
- indexPredication.setStopValue(indexPredicationValues.getSecond());
-
- indexPredications.add(indexPredication);
- }
- }
+ final Column[] indexableColumns = getIndexableColumns(tableDesc);
+ if (indexableColumns == null && indexableColumns.length == 0) {
--- End diff --
Thank you for the comment. I'll fix it and then commit it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1990: Refine some parts in HBaseTablespace...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/880#issuecomment-164379383
Fixed that. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1990: Refine some parts in HBaseTablespace...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/880#issuecomment-164361703
@hyunsik
Could you check this error?
```
2015-12-14 15:55:20,180 FATAL org.apache.tajo.master.TajoMaster: Error starting TajoMaster
java.lang.NoClassDefFoundError: org/apache/hadoop/hbase/HConstants
at org.apache.tajo.storage.hbase.HBaseTablespace.<clinit>(HBaseTablespace.java:76)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:264)
at org.apache.tajo.storage.TablespaceManager.extractStorage(TablespaceManager.java:185)
at org.apache.tajo.storage.TablespaceManager.loadStorages(TablespaceManager.java:166)
at org.apache.tajo.storage.TablespaceManager.applyConfig(TablespaceManager.java:154)
at org.apache.tajo.storage.TablespaceManager.initForDefaultConfig(TablespaceManager.java:120)
at org.apache.tajo.storage.TablespaceManager.<init>(TablespaceManager.java:93)
at org.apache.tajo.storage.TablespaceManager.<clinit>(TablespaceManager.java:84)
at org.apache.tajo.master.TajoMaster.serviceInit(TajoMaster.java:183)
at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
at org.apache.tajo.master.TajoMaster.main(TajoMaster.java:597)
Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hbase.HConstants
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 12 more
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1990: Refine some parts in HBaseTablespace...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/880
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---