You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2023/08/23 19:09:15 UTC
[GitHub] [superset] rusackas opened a new pull request, #25065: feat: adding Scarf pixels to gather telemetry on readme and website
rusackas opened a new pull request, #25065:
URL: https://github.com/apache/superset/pull/25065
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR adds two distinct tracking pixels for telemetry, using the Scarf platform. One is added to the readme to capture analytics around visits to the repo, and one captures visits to the website/docs.
All of this data will be available to interested PMC members, and reported periodically in things like Superset Board Reports and Superset Town Hall events.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Log into Scarf and see the charts ticking!
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #25065: feat: adding Scarf pixels to gather telemetry on readme and website
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #25065:
URL: https://github.com/apache/superset/pull/25065#discussion_r1303521604
##########
docs/docusaurus.config.js:
##########
@@ -252,7 +252,9 @@ const config = {
<a href="https://apache.org/events/current-event" target="_blank" rel="noreferrer">Events</a> |
<a href="https://apache.org/licenses/" target="_blank" rel="noreferrer">License</a>
</small>
- </p>`,
+ </p>
+ <img referrerPolicy="no-referrer-when-downgrade" src="https://static.scarf.sh/a.png?x-pxid=39ae6855-95fc-4566-86e5-360d542b0a68" />
Review Comment:
Should we add `<!-- telemetry/analytics pixel: -->` here, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #25065: feat: adding Scarf pixels to gather telemetry on readme and website
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #25065:
URL: https://github.com/apache/superset/pull/25065#issuecomment-1690646310
> @rusackas btw, there's also `CONTRIBUTING.md` that we may want to track, and maybe the `resources/INTHEWILD.md` and other friends, too
Yes indeed... and the wiki, potentially... lots more to expand into.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #25065: feat: adding Scarf pixels to gather telemetry on readme and website
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #25065:
URL: https://github.com/apache/superset/pull/25065#issuecomment-1690630380
@rusackas btw, there's also `CONTRIBUTING.md` that we may want to track, and maybe the `resources/INTHEWILD.md` and other friends, too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #25065: feat: adding Scarf pixels to gather telemetry on readme and website
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #25065:
URL: https://github.com/apache/superset/pull/25065#issuecomment-1690645664
I'll add something to the docs and/or readme about telemetry about the aggregated data collected from processing (and the deleting) your IP, though ironically you would have been pixellated(?) by the time you've read it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #25065: feat: adding Scarf pixels to gather telemetry on readme and website
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #25065:
URL: https://github.com/apache/superset/pull/25065#discussion_r1303523175
##########
docs/docusaurus.config.js:
##########
@@ -252,7 +252,9 @@ const config = {
<a href="https://apache.org/events/current-event" target="_blank" rel="noreferrer">Events</a> |
<a href="https://apache.org/licenses/" target="_blank" rel="noreferrer">License</a>
</small>
- </p>`,
+ </p>
Review Comment:
```suggestion
</p>
<!-- telemetry/analytics pixel: -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #25065: feat: adding Scarf pixels to gather telemetry on readme and website
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #25065:
URL: https://github.com/apache/superset/pull/25065#issuecomment-1690514459
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/25065?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#25065](https://app.codecov.io/gh/apache/superset/pull/25065?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a0ef7ab) into [master](https://app.codecov.io/gh/apache/superset/commit/adaab3550c4487b17868a8880cfa146a7806422a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (adaab35) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #25065 +/- ##
==========================================
- Coverage 58.49% 58.34% -0.15%
==========================================
Files 1906 1906
Lines 74625 74625
Branches 8208 8208
==========================================
- Hits 43650 43540 -110
- Misses 28845 28955 +110
Partials 2130 2130
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/25065/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/25065/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/25065/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.67% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/25065/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.97% <ø> (-0.31%)` | :arrow_down: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/25065/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.08% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 7 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/25065/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #25065: feat: adding Scarf pixels to gather telemetry on readme and website
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #25065:
URL: https://github.com/apache/superset/pull/25065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org