You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Udara Liyanage <ud...@wso2.com> on 2015/01/14 12:57:31 UTC
CLI add-service-group add-cartridge-group mismatch
Hi,
CLI has add-cartridge-group command, but undeploy-service-group. I guess it
should be undeploy-cartridge-group. Isn't is better to use just get-group
and undeploy group since we have only cartridge groups
undeploy-groups command calls DELETE /groups/{group-id} endpoint.
--
Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware
web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897
Re: CLI add-service-group add-cartridge-group mismatch
Posted by Shiroshica Kulatilake <sh...@wso2.com>.
Changes sent in PR https://github.com/apache/stratos/pull/169
Thank you,
Shiro
Shiroshica Kulatilake
WSO2, Inc. http://wso2.com/
Phone: +94 776523867
On Fri, Jan 16, 2015 at 9:57 AM, Imesh Gunaratne <im...@apache.org> wrote:
> Thanks Shiro, appreciate it! I can fix the terminology usage and domain
> mapping commands. Please send a PR once you are done.
>
> Thanks
>
> On Fri, Jan 16, 2015 at 9:37 AM, Shiroshica Kulatilake <sh...@wso2.com>
> wrote:
>
>> Hi,
>>
>> I'm in the middle of adding cli commands for application and application
>> sign up.
>>
>> I can incorporate this change as well if needed.
>>
>> Thank you,
>> Shiro
>>
>> Shiroshica Kulatilake
>>
>> WSO2, Inc. http://wso2.com/
>> Phone: +94 776523867
>>
>> On Fri, Jan 16, 2015 at 9:29 AM, Imesh Gunaratne <im...@apache.org>
>> wrote:
>>
>>> Actually it should be remove-cartridge-group. We only use the term
>>> "deploy" for applications now. All other artifacts are added and removed. I
>>> will fix this.
>>>
>>> Thanks
>>>
>>> On Wed, Jan 14, 2015 at 5:27 PM, Udara Liyanage <ud...@wso2.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> CLI has add-cartridge-group command, but undeploy-service-group. I
>>>> guess it should be undeploy-cartridge-group. Isn't is better to use just
>>>> get-group and undeploy group since we have only cartridge groups
>>>>
>>>> undeploy-groups command calls DELETE /groups/{group-id} endpoint.
>>>> --
>>>>
>>>> Udara Liyanage
>>>> Software Engineer
>>>> WSO2, Inc.: http://wso2.com
>>>> lean. enterprise. middleware
>>>>
>>>> web: http://udaraliyanage.wordpress.com
>>>> phone: +94 71 443 6897
>>>>
>>>
>>>
>>>
>>> --
>>> Imesh Gunaratne
>>>
>>> Technical Lead, WSO2
>>> Committer & PMC Member, Apache Stratos
>>>
>>
>>
>
>
> --
> Imesh Gunaratne
>
> Technical Lead, WSO2
> Committer & PMC Member, Apache Stratos
>
Re: CLI add-service-group add-cartridge-group mismatch
Posted by Imesh Gunaratne <im...@apache.org>.
Thanks Shiro, appreciate it! I can fix the terminology usage and domain
mapping commands. Please send a PR once you are done.
Thanks
On Fri, Jan 16, 2015 at 9:37 AM, Shiroshica Kulatilake <sh...@wso2.com>
wrote:
> Hi,
>
> I'm in the middle of adding cli commands for application and application
> sign up.
>
> I can incorporate this change as well if needed.
>
> Thank you,
> Shiro
>
> Shiroshica Kulatilake
>
> WSO2, Inc. http://wso2.com/
> Phone: +94 776523867
>
> On Fri, Jan 16, 2015 at 9:29 AM, Imesh Gunaratne <im...@apache.org> wrote:
>
>> Actually it should be remove-cartridge-group. We only use the term
>> "deploy" for applications now. All other artifacts are added and removed. I
>> will fix this.
>>
>> Thanks
>>
>> On Wed, Jan 14, 2015 at 5:27 PM, Udara Liyanage <ud...@wso2.com> wrote:
>>
>>> Hi,
>>>
>>> CLI has add-cartridge-group command, but undeploy-service-group. I guess
>>> it should be undeploy-cartridge-group. Isn't is better to use just
>>> get-group and undeploy group since we have only cartridge groups
>>>
>>> undeploy-groups command calls DELETE /groups/{group-id} endpoint.
>>> --
>>>
>>> Udara Liyanage
>>> Software Engineer
>>> WSO2, Inc.: http://wso2.com
>>> lean. enterprise. middleware
>>>
>>> web: http://udaraliyanage.wordpress.com
>>> phone: +94 71 443 6897
>>>
>>
>>
>>
>> --
>> Imesh Gunaratne
>>
>> Technical Lead, WSO2
>> Committer & PMC Member, Apache Stratos
>>
>
>
--
Imesh Gunaratne
Technical Lead, WSO2
Committer & PMC Member, Apache Stratos
Re: CLI add-service-group add-cartridge-group mismatch
Posted by Shiroshica Kulatilake <sh...@wso2.com>.
Hi,
I'm in the middle of adding cli commands for application and application
sign up.
I can incorporate this change as well if needed.
Thank you,
Shiro
Shiroshica Kulatilake
WSO2, Inc. http://wso2.com/
Phone: +94 776523867
On Fri, Jan 16, 2015 at 9:29 AM, Imesh Gunaratne <im...@apache.org> wrote:
> Actually it should be remove-cartridge-group. We only use the term
> "deploy" for applications now. All other artifacts are added and removed. I
> will fix this.
>
> Thanks
>
> On Wed, Jan 14, 2015 at 5:27 PM, Udara Liyanage <ud...@wso2.com> wrote:
>
>> Hi,
>>
>> CLI has add-cartridge-group command, but undeploy-service-group. I guess
>> it should be undeploy-cartridge-group. Isn't is better to use just
>> get-group and undeploy group since we have only cartridge groups
>>
>> undeploy-groups command calls DELETE /groups/{group-id} endpoint.
>> --
>>
>> Udara Liyanage
>> Software Engineer
>> WSO2, Inc.: http://wso2.com
>> lean. enterprise. middleware
>>
>> web: http://udaraliyanage.wordpress.com
>> phone: +94 71 443 6897
>>
>
>
>
> --
> Imesh Gunaratne
>
> Technical Lead, WSO2
> Committer & PMC Member, Apache Stratos
>
Re: CLI add-service-group add-cartridge-group mismatch
Posted by Imesh Gunaratne <im...@apache.org>.
Actually it should be remove-cartridge-group. We only use the term "deploy"
for applications now. All other artifacts are added and removed. I will fix
this.
Thanks
On Wed, Jan 14, 2015 at 5:27 PM, Udara Liyanage <ud...@wso2.com> wrote:
> Hi,
>
> CLI has add-cartridge-group command, but undeploy-service-group. I guess
> it should be undeploy-cartridge-group. Isn't is better to use just
> get-group and undeploy group since we have only cartridge groups
>
> undeploy-groups command calls DELETE /groups/{group-id} endpoint.
> --
>
> Udara Liyanage
> Software Engineer
> WSO2, Inc.: http://wso2.com
> lean. enterprise. middleware
>
> web: http://udaraliyanage.wordpress.com
> phone: +94 71 443 6897
>
--
Imesh Gunaratne
Technical Lead, WSO2
Committer & PMC Member, Apache Stratos