You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by anoopsharma00 <gi...@git.apache.org> on 2016/03/13 02:53:38 UTC
[GitHub] incubator-trafodion pull request: JIRA 1849 Add support for alter ...
GitHub user anoopsharma00 opened a pull request:
https://github.com/apache/incubator-trafodion/pull/381
JIRA 1849 Add support for alter column rename (details below)
-- support for 'add column c rename to newc'
-- fixed issue with ddl stmts and aqr, it now works correctly
if ddl_transactions are being used
-- drop table with views now drops them in reverse creation order.
That way dependent views are dropped correctly.
-- views are dropped before and recreated after an alter column
statement.
-- dev regressions tests now show system columns in invoke.
-- index uid is now stored in desc and NATable structs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anoopsharma00/incubator-trafodion altcolren_br_deliver
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/381.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #381
----
commit d406cc524027bd07380db4e6c0726c6e76c349e4
Author: Cloud User <ce...@ansharma-3.novalocal>
Date: 2016-03-13T01:32:25Z
JIRA 1849 Add support for alter column rename (details below)
-- support for 'add column c rename to newc'
-- fixed issue with ddl stmts and aqr, it now works correctly
if ddl_transactions are being used
-- drop table with views now drops them in reverse creation order.
That way dependent views are dropped correctly.
-- views are dropped before and recreated after an alter column
statement.
-- dev regressions tests now show system columns in invoke.
-- index uid is now stored in desc and NATable structs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: JIRA 1849 Add support for alter ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/381#discussion_r56028824
--- Diff: core/sql/regress/charsets/EXPECTED012 ---
@@ -120,11 +121,11 @@ tomorrow_suffix
>>select a || _ucs2'_suffix' from tlongwvarchar1;
(EXPR)
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------
+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
------------------------------
--- End diff --
I take it the character set synthesis rules changed somewhere? The new results seem to be twice as long as the old.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: JIRA 1849 Add support for alter ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/381#discussion_r56029329
--- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
@@ -2691,7 +2668,7 @@ short CmpDescribeSeabaseTable (
// display syscols for invoke if not running regrs
--- End diff --
Comment needs updating?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: JIRA 1849 Add support for alter ...
Posted by anoopsharma00 <gi...@git.apache.org>.
Github user anoopsharma00 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/381#discussion_r56413042
--- Diff: core/sql/common/NAString.cpp ---
@@ -280,6 +280,29 @@ NAString Int64ToNAString(Int64 l)
return NAString(resultstr);
}
+NAString &replaceAll(NAString &source, const NAString &searchFor,
+ const NAString &replaceWith)
+{
+ size_t indexOfReplace = NA_NPOS;
+ indexOfReplace = source.index(searchFor);
+ if (indexOfReplace != NA_NPOS)
--- End diff --
yes, that is true.
This method was moved from sqlcomp/CmpDescribe.cpp to common dir
and is not new code.
Will fix it in a later checkin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: JIRA 1849 Add support for alter ...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/381#discussion_r56027243
--- Diff: core/sql/common/NAString.cpp ---
@@ -280,6 +280,29 @@ NAString Int64ToNAString(Int64 l)
return NAString(resultstr);
}
+NAString &replaceAll(NAString &source, const NAString &searchFor,
+ const NAString &replaceWith)
+{
+ size_t indexOfReplace = NA_NPOS;
+ indexOfReplace = source.index(searchFor);
+ if (indexOfReplace != NA_NPOS)
--- End diff --
The "if" is unnecessary. If you delete it, the code behaves exactly as it would have otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: JIRA 1849 Add support for alter ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/381
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---