You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2017/01/05 18:00:53 UTC
Re: Review Request 54688: Added a `docker_store_dir` flag to tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54688/
-----------------------------------------------------------
(Updated Jan. 5, 2017, 6 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Linked it to the ASF Jira.
Bugs: MESOS-6847
https://issues.apache.org/jira/browse/MESOS-6847
Repository: mesos
Description
-------
We can use this field to set a docker store directory for the
`MesosContainerizer` for each test run. This will greatly speed up the
tests using docker images with the `MesosContainerizer`.
Diffs
-----
src/tests/containerizer/cni_isolator_tests.cpp b032c4345683813bca5f9a5eec09f73d860299cc
src/tests/environment.cpp ba75043a2a3813c70ed99aecfd979ba305d7a383
src/tests/flags.hpp cab24162e26be9fe79c0c65f24e35e3c3d735906
src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043
src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd
Diff: https://reviews.apache.org/r/54688/diff/
Testing (updated)
-------
sudo make check
Thanks,
Avinash sridharan
Re: Review Request 54688: Added a `docker_store_dir` flag to tests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54688/#review160677
-----------------------------------------------------------
Bad review!
Reviews applied: [54688, 52773, 52772, 53264]
Error:
Circular dependency detected for review 52773.Please fix the 'depends_on' field.
- Mesos ReviewBot
On Jan. 5, 2017, 10:15 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54688/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 10:15 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-6847
> https://issues.apache.org/jira/browse/MESOS-6847
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We can use this field to set a docker store directory for the
> `MesosContainerizer` for each test run. This will greatly speed up the
> tests using docker images with the `MesosContainerizer`.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp a683d8c221635f81906abbead1e01d2469850d93
> src/tests/flags.hpp cab24162e26be9fe79c0c65f24e35e3c3d735906
> src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043
> src/tests/mesos.cpp adbb697c2bb908a584163dc9954b9e3138164433
>
> Diff: https://reviews.apache.org/r/54688/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 54688: Added a `docker_store_dir` flag to tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54688/#review170226
-----------------------------------------------------------
src/tests/environment.cpp
Lines 846-855 (patched)
<https://reviews.apache.org/r/54688/#comment243011>
I'd prefer we use TestEventListener here so that it's consistent with others:
```
testing::TestEventListener::OnEnvironmentsSetUpEnd
```
src/tests/flags.hpp
Lines 170 (patched)
<https://reviews.apache.org/r/54688/#comment243009>
Can you add a `add` method in the constructor?
src/tests/main.cpp
Lines 161-162 (patched)
<https://reviews.apache.org/r/54688/#comment243007>
This might break windows tests?
src/tests/main.cpp
Lines 170 (patched)
<https://reviews.apache.org/r/54688/#comment243008>
why you need path join here?
src/tests/mesos.cpp
Lines 246 (patched)
<https://reviews.apache.org/r/54688/#comment243012>
Add some comments for this.
- Jie Yu
On Jan. 5, 2017, 10:15 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54688/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2017, 10:15 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-6847
> https://issues.apache.org/jira/browse/MESOS-6847
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We can use this field to set a docker store directory for the
> `MesosContainerizer` for each test run. This will greatly speed up the
> tests using docker images with the `MesosContainerizer`.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp a683d8c221635f81906abbead1e01d2469850d93
> src/tests/flags.hpp cab24162e26be9fe79c0c65f24e35e3c3d735906
> src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043
> src/tests/mesos.cpp adbb697c2bb908a584163dc9954b9e3138164433
>
>
> Diff: https://reviews.apache.org/r/54688/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 54688: Added a `docker_store_dir` flag to tests.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54688/
-----------------------------------------------------------
(Updated Jan. 5, 2017, 10:15 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Rebased
Bugs: MESOS-6847
https://issues.apache.org/jira/browse/MESOS-6847
Repository: mesos
Description
-------
We can use this field to set a docker store directory for the
`MesosContainerizer` for each test run. This will greatly speed up the
tests using docker images with the `MesosContainerizer`.
Diffs (updated)
-----
src/tests/environment.cpp a683d8c221635f81906abbead1e01d2469850d93
src/tests/flags.hpp cab24162e26be9fe79c0c65f24e35e3c3d735906
src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043
src/tests/mesos.cpp adbb697c2bb908a584163dc9954b9e3138164433
Diff: https://reviews.apache.org/r/54688/diff/
Testing
-------
sudo make check
Thanks,
Avinash sridharan