You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ilya Berezhniuk (JIRA)" <ji...@apache.org> on 2006/12/28 23:12:21 UTC
[jira] Created: (HARMONY-2917) [drlvm][jvmti][em64t] Incorrect
JVMTI monitor exit stub
[drlvm][jvmti][em64t] Incorrect JVMTI monitor exit stub
-------------------------------------------------------
Key: HARMONY-2917
URL: http://issues.apache.org/jira/browse/HARMONY-2917
Project: Harmony
Issue Type: Bug
Components: DRLVM
Environment: em64t
Reporter: Ilya Berezhniuk
When JVMTI is enabled, rth_get_lil_monitor_exit_generic() function generates special stub version for monitor exit.
But LIL code for JVMTI is incorrect, so assertion occurs on lil_is_valid() check.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2917) [drlvm][jvmti][em64t] Incorrect
JVMTI monitor exit stub
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2917?page=all ]
Ilya Berezhniuk updated HARMONY-2917:
-------------------------------------
Patch Info: [Patch Available]
> [drlvm][jvmti][em64t] Incorrect JVMTI monitor exit stub
> -------------------------------------------------------
>
> Key: HARMONY-2917
> URL: http://issues.apache.org/jira/browse/HARMONY-2917
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: em64t
> Reporter: Ilya Berezhniuk
> Attachments: mon_exit_em64t.patch
>
>
> When JVMTI is enabled, rth_get_lil_monitor_exit_generic() function generates special stub version for monitor exit.
> But LIL code for JVMTI is incorrect, so assertion occurs on lil_is_valid() check.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2917) [drlvm][jvmti][em64t] Incorrect
JVMTI monitor exit stub
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2917?page=all ]
Ilya Berezhniuk updated HARMONY-2917:
-------------------------------------
Attachment: mon_exit_em64t.patch
Suggested patch fixes JVMTI slow path for monitor exit stub.
It looks like difference in preformance will be minimal.
> [drlvm][jvmti][em64t] Incorrect JVMTI monitor exit stub
> -------------------------------------------------------
>
> Key: HARMONY-2917
> URL: http://issues.apache.org/jira/browse/HARMONY-2917
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: em64t
> Reporter: Ilya Berezhniuk
> Attachments: mon_exit_em64t.patch
>
>
> When JVMTI is enabled, rth_get_lil_monitor_exit_generic() function generates special stub version for monitor exit.
> But LIL code for JVMTI is incorrect, so assertion occurs on lil_is_valid() check.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2917) [drlvm][jvmti][em64t] Incorrect JVMTI
monitor exit stub
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky closed HARMONY-2917.
--------------------------------------
Resolution: Fixed
Patch applied at 494447.
> [drlvm][jvmti][em64t] Incorrect JVMTI monitor exit stub
> -------------------------------------------------------
>
> Key: HARMONY-2917
> URL: https://issues.apache.org/jira/browse/HARMONY-2917
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: em64t
> Reporter: Ilya Berezhniuk
> Assigned To: Gregory Shimansky
> Attachments: mon_exit_em64t.patch, mon_exit_em64t.patch
>
>
> When JVMTI is enabled, rth_get_lil_monitor_exit_generic() function generates special stub version for monitor exit.
> But LIL code for JVMTI is incorrect, so assertion occurs on lil_is_valid() check.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2917) [drlvm][jvmti][em64t] Incorrect
JVMTI monitor exit stub
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2917?page=comments#action_12461271 ]
Gregory Shimansky commented on HARMONY-2917:
--------------------------------------------
While JVMTI implementation was not yet designed for x86_64, this case might be a real bug in threading implementation and could be fixed without heavy changes in components like JIT. OHOH LIL for x86_64 might be lacking some functionality too.
> [drlvm][jvmti][em64t] Incorrect JVMTI monitor exit stub
> -------------------------------------------------------
>
> Key: HARMONY-2917
> URL: http://issues.apache.org/jira/browse/HARMONY-2917
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: em64t
> Reporter: Ilya Berezhniuk
>
> When JVMTI is enabled, rth_get_lil_monitor_exit_generic() function generates special stub version for monitor exit.
> But LIL code for JVMTI is incorrect, so assertion occurs on lil_is_valid() check.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-2917) [drlvm][jvmti][em64t] Incorrect
JVMTI monitor exit stub
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2917?page=all ]
Gregory Shimansky reassigned HARMONY-2917:
------------------------------------------
Assignee: Gregory Shimansky
> [drlvm][jvmti][em64t] Incorrect JVMTI monitor exit stub
> -------------------------------------------------------
>
> Key: HARMONY-2917
> URL: http://issues.apache.org/jira/browse/HARMONY-2917
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: em64t
> Reporter: Ilya Berezhniuk
> Assigned To: Gregory Shimansky
> Attachments: mon_exit_em64t.patch, mon_exit_em64t.patch
>
>
> When JVMTI is enabled, rth_get_lil_monitor_exit_generic() function generates special stub version for monitor exit.
> But LIL code for JVMTI is incorrect, so assertion occurs on lil_is_valid() check.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2917) [drlvm][jvmti][em64t] Incorrect
JVMTI monitor exit stub
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2917?page=all ]
Ilya Berezhniuk updated HARMONY-2917:
-------------------------------------
Attachment: mon_exit_em64t.patch
This patch fixes issue too, but it's much better than previous.
It affects only generic monitor exit stub, and only JVMTI slow path.
> [drlvm][jvmti][em64t] Incorrect JVMTI monitor exit stub
> -------------------------------------------------------
>
> Key: HARMONY-2917
> URL: http://issues.apache.org/jira/browse/HARMONY-2917
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: em64t
> Reporter: Ilya Berezhniuk
> Attachments: mon_exit_em64t.patch, mon_exit_em64t.patch
>
>
> When JVMTI is enabled, rth_get_lil_monitor_exit_generic() function generates special stub version for monitor exit.
> But LIL code for JVMTI is incorrect, so assertion occurs on lil_is_valid() check.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira