You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/11 09:41:39 UTC
[GitHub] [flink] fapaul opened a new pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
fapaul opened a new pull request #18325:
URL: https://github.com/apache/flink/pull/18325
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Our metrics classes are already treated as if they are public. This PR annotates the bases classes with `@Public` and the metrics helper exposed to the connectors with `@PublicEvolving`. We also fix some of our arch unit test by introducing the annotations
The change was initially required by #18302.
## Brief change log
- Annotate metrics classes with public annotations
## Verifying this change
- Arch unit tests still pass
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009823471
> Do you think all classes inside the metrics-core module should be annotated?
All interfaces + the `AbstractReporter/HistogramStatistics/MetricConfig` classes I think.
The remaining classes (SimpleCounter, MeterView, UnregisteredMetricsGroup) should be `@Internal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009773136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29246",
"triggerID" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 549e1b1567d93cc4a94046379561cf2313a375aa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29246)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009773136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29246",
"triggerID" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"triggerType" : "PUSH"
}, {
"hash" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264",
"triggerID" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64b079874e49a799781fd2a830aa77bbd513cf1e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009769706
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 549e1b1567d93cc4a94046379561cf2313a375aa (Tue Jan 11 09:44:40 UTC 2022)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009807430
> How did you decide which classes should be public? I see that `Metric` and all extending interfaces are `Public`, yet `View` isn't despite being an extension for metrics.
>
> Why are the reporter interfaces not annotated?
Good question, I mainly went through the metrics classes relevant for connectors. Do you think all classes inside the `metrics-core` module should be annotated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #18325:
URL: https://github.com/apache/flink/pull/18325#discussion_r782118007
##########
File path: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/LogicalScopeProvider.java
##########
@@ -17,13 +17,16 @@
package org.apache.flink.metrics;
+import org.apache.flink.annotation.Public;
+
/**
* Extension for metric groups that support logical scopes.
*
* <p>ATTENTION: This interface is *not* meant for the long-term; it merely removes the need for
* reporters to depend on flink-runtime in order to access the logical scope. Once the logical scope
* is properly exposed this interface *will* be removed.
*/
+@Public
Review comment:
@zentol can you confirm this annotation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009773136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29246",
"triggerID" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"triggerType" : "PUSH"
}, {
"hash" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264",
"triggerID" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"triggerType" : "PUSH"
}, {
"hash" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264",
"triggerID" : "1010870404",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 64b079874e49a799781fd2a830aa77bbd513cf1e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #18325:
URL: https://github.com/apache/flink/pull/18325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009773136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29246",
"triggerID" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"triggerType" : "PUSH"
}, {
"hash" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 549e1b1567d93cc4a94046379561cf2313a375aa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29246)
* 64b079874e49a799781fd2a830aa77bbd513cf1e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009773136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 549e1b1567d93cc4a94046379561cf2313a375aa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009773136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29246",
"triggerID" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"triggerType" : "PUSH"
}, {
"hash" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264",
"triggerID" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"triggerType" : "PUSH"
}, {
"hash" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264",
"triggerID" : "1010870404",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 64b079874e49a799781fd2a830aa77bbd513cf1e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009767785
@zentol I extracted the metrics API annotations to a separate ticket please have another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009773136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29246",
"triggerID" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"triggerType" : "PUSH"
}, {
"hash" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264",
"triggerID" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 549e1b1567d93cc4a94046379561cf2313a375aa Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29246)
* 64b079874e49a799781fd2a830aa77bbd513cf1e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009773136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29246",
"triggerID" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"triggerType" : "PUSH"
}, {
"hash" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264",
"triggerID" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 549e1b1567d93cc4a94046379561cf2313a375aa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29246)
* 64b079874e49a799781fd2a830aa77bbd513cf1e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1010870404
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18325:
URL: https://github.com/apache/flink/pull/18325#issuecomment-1009773136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29246",
"triggerID" : "549e1b1567d93cc4a94046379561cf2313a375aa",
"triggerType" : "PUSH"
}, {
"hash" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264",
"triggerID" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"triggerType" : "PUSH"
}, {
"hash" : "64b079874e49a799781fd2a830aa77bbd513cf1e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264",
"triggerID" : "1010870404",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 64b079874e49a799781fd2a830aa77bbd513cf1e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29264)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18325: [FLINK-25608][metrics] Annotate metrics classes with Public(Evolving)
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18325:
URL: https://github.com/apache/flink/pull/18325#discussion_r782853586
##########
File path: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/LogicalScopeProvider.java
##########
@@ -17,13 +17,16 @@
package org.apache.flink.metrics;
+import org.apache.flink.annotation.Public;
+
/**
* Extension for metric groups that support logical scopes.
*
* <p>ATTENTION: This interface is *not* meant for the long-term; it merely removes the need for
* reporters to depend on flink-runtime in order to access the logical scope. Once the logical scope
* is properly exposed this interface *will* be removed.
*/
+@Public
Review comment:
yes this should be fine. While we do intend to drop it in 2.0, until then it should remain stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org