You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2024/05/14 02:32:08 UTC
[PR] [SPARK-48265][SQL] Infer window group limit batch should do constant folding [spark]
AngersZhuuuu opened a new pull request, #46568:
URL: https://github.com/apache/spark/pull/46568
### What changes were proposed in this pull request?
Plan after PropagateEmptyRelation may generate double local limit
```
GlobalLimit 21
+- LocalLimit 21
! +- Union false, false
! :- LocalLimit 21
! : +- Project [item_id#647L]
! : +- Filter (xxxx)
! : +- Relation db.table[,... 91 more fields] parquet
! +- LocalLimit 21
! +- Project [item_id#738L]
! +- LocalRelation <empty>, [, ... 91 more fields]
```
to
```
GlobalLimit 21
+- LocalLimit 21
- LocalLimit 21
+- Project [item_id#647L]
+- Filter (xxxx)
+- Relation db.table[,... 91 more fields] parquet
```
after `Infer window group limit batch` batch's `EliminateLimits`
will be
```
GlobalLimit 21
+- LocalLimit least(21, 21)
+- Project [item_id#647L]
+- Filter (xxxx)
+- Relation db.table[,... 91 more fields] parquet
```
It can't work, here miss a `ConstantFolding`
### Why are the changes needed?
Fix bug
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48265][SQL] Infer window group limit batch should do constant folding [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #46568:
URL: https://github.com/apache/spark/pull/46568#issuecomment-2109342800
LGTM later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48265][SQL] Infer window group limit batch should do constant folding [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #46568: [SPARK-48265][SQL] Infer window group limit batch should do constant folding
URL: https://github.com/apache/spark/pull/46568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48265][SQL] Infer window group limit batch should do constant folding [spark]
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #46568:
URL: https://github.com/apache/spark/pull/46568#issuecomment-2109161898
ping @cloud-fan cc @beliefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-48265][SQL] Infer window group limit batch should do constant folding [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #46568:
URL: https://github.com/apache/spark/pull/46568#issuecomment-2109331575
thanks, merging to master/3.5!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org