[GitHub] [camel-quarkus] aldettinger commented on pull request #4030: Pass encrypt property to Debezium MS SQL Server JDBC URL

[GitBox <gi...@apache.org>]

aldettinger commented on PR #4030:
URL: https://github.com/apache/camel-quarkus/pull/4030#issuecomment-1223723943

   @jamesnetherton Great to have multiple commits. It looks easier to review actually. Maybe, that could become a general practise to keep distinct commits during reviews. Maybe sometimes, squashing at the end of review would be needed...
   
   Reading the EULA, It looks ok for to use in itests. However, couldn't we have issues when someone clone the repository and run itests on its own machine.
   
   For instance, the EULA mention US export restriction law. When calling `acceptLicense()`, it could mean that explicit consent would be given that the MS SQL database is run in a country that is not subject to US export restrictions. However, anybody can clone this code and use it in another country subject to US export restrictions...
   
   That said, it's a tricky question. Maybe we should ask Apache legal ? Or maybe we should keep a kind of express consent in a simpler form, like an environment variable `QUARKUS_***_ACCEPT_MS_SQL_EULA=True` ? It could be true on CI and one would need to set it to true when running locally ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org