You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "LakeShen (Jira)" <ji...@apache.org> on 2023/08/13 08:47:00 UTC

[jira] [Updated] (CALCITE-5906) Add the visit(Sample e) implementation in RelToSqlConverter

     [ https://issues.apache.org/jira/browse/CALCITE-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

LakeShen updated CALCITE-5906:
------------------------------
    Summary: Add the visit(Sample e) implementation  in RelToSqlConverter   (was: RelToSqlConverter throw AssertionError when RelNode tree has the Sample RelNode)

> Add the visit(Sample e) implementation  in RelToSqlConverter 
> -------------------------------------------------------------
>
>                 Key: CALCITE-5906
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5906
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: LakeShen
>            Assignee: LakeShen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.36.0
>
>         Attachments: image-2023-08-08-20-16-27-188.png, image-2023-08-08-20-19-01-269.png
>
>
> Currently in the RelToSqlConverter class, there is no visit method to handle the Sample RelNode.If a SQL plan has Sample RelNode, RelToSqlConverter will throw a AssertionError like this:
> {code:java}
>  java.lang.AssertionError: Need to implement org.apache.calcite.rel.core.Sample
> {code}
> This will cause the Sample RelNode plan to fail to translate to the corresponding dialect.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)