You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/30 04:10:49 UTC

[GitHub] [calcite] hannerwang opened a new pull request #2665: [CALCITE-4901] RelToSqlConverter adds redundant order by output column for the result sql

hannerwang opened a new pull request #2665:
URL: https://github.com/apache/calcite/pull/2665


   …n for the result sql


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] hannerwang commented on pull request #2665: [CALCITE-4901] RelToSqlConverter adds redundant order by output column for the result sql

Posted by GitBox <gi...@apache.org>.
hannerwang commented on pull request #2665:
URL: https://github.com/apache/calcite/pull/2665#issuecomment-1007097386


   The Druid tests failed because of timeout, I don't know how to trigger it rerun, could any one gives advice to resolve it? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] NobiGo commented on a change in pull request #2665: [CALCITE-4901] RelToSqlConverter adds redundant order by output column for the result sql

Posted by GitBox <gi...@apache.org>.
NobiGo commented on a change in pull request #2665:
URL: https://github.com/apache/calcite/pull/2665#discussion_r778607124



##########
File path: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -1545,7 +1556,7 @@ private void checkHavingAliasSameAsColumn(boolean upperAlias) {
     String query = "select \"product_id\" from \"product\" "
         + "order by \"net_weight\" asc, \"gross_weight\" desc, \"low_fat\"";
     final String expected = "SELECT"
-        + " \"product_id\", \"net_weight\", \"gross_weight\", \"low_fat\"\n"
+        + " \"product_id\"\n"

Review comment:
       Please reformat the Sql with line break.
   ```
   "SELECT \"product_id\"\n"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] hannerwang commented on pull request #2665: [CALCITE-4901] RelToSqlConverter adds redundant order by output column for the result sql

Posted by GitBox <gi...@apache.org>.
hannerwang commented on pull request #2665:
URL: https://github.com/apache/calcite/pull/2665#issuecomment-1007830449


   > > The Druid tests failed because of timeout, I don't know how to trigger it rerun, could any one gives advice to resolve it?
   > 
   > According to https://calcite.apache.org/develop/#contributing
   > 
   > In the special case, that the CI build failed, and the failure is not caused by your changes create an empty commit (git commit --allow-empty) and push it.
   
   Thanks,  Fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] hannerwang commented on a change in pull request #2665: [CALCITE-4901] RelToSqlConverter adds redundant order by output column for the result sql

Posted by GitBox <gi...@apache.org>.
hannerwang commented on a change in pull request #2665:
URL: https://github.com/apache/calcite/pull/2665#discussion_r778649371



##########
File path: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -1545,7 +1556,7 @@ private void checkHavingAliasSameAsColumn(boolean upperAlias) {
     String query = "select \"product_id\" from \"product\" "
         + "order by \"net_weight\" asc, \"gross_weight\" desc, \"low_fat\"";
     final String expected = "SELECT"
-        + " \"product_id\", \"net_weight\", \"gross_weight\", \"low_fat\"\n"
+        + " \"product_id\"\n"

Review comment:
       Fixed, Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] asfgit closed pull request #2665: [CALCITE-4901] RelToSqlConverter adds redundant order by output column for the result sql

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2665:
URL: https://github.com/apache/calcite/pull/2665


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] hannerwang commented on pull request #2665: [CALCITE-4901] RelToSqlConverter adds redundant order by output column for the result sql

Posted by GitBox <gi...@apache.org>.
hannerwang commented on pull request #2665:
URL: https://github.com/apache/calcite/pull/2665#issuecomment-1007830449


   > > The Druid tests failed because of timeout, I don't know how to trigger it rerun, could any one gives advice to resolve it?
   > 
   > According to https://calcite.apache.org/develop/#contributing
   > 
   > In the special case, that the CI build failed, and the failure is not caused by your changes create an empty commit (git commit --allow-empty) and push it.
   
   Thanks,  Fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] NobiGo commented on pull request #2665: [CALCITE-4901] RelToSqlConverter adds redundant order by output column for the result sql

Posted by GitBox <gi...@apache.org>.
NobiGo commented on pull request #2665:
URL: https://github.com/apache/calcite/pull/2665#issuecomment-1007168740


   > The Druid tests failed because of timeout, I don't know how to trigger it rerun, could any one gives advice to resolve it?
   
   According to https://calcite.apache.org/develop/#contributing
   
   In the special case, that the CI build failed, and the failure is not caused by your changes create an empty commit (git commit --allow-empty) and push it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org