You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/27 21:08:42 UTC

[GitHub] [fineract] nnatarajan opened a new pull request #944: FINERACT-966 Bump dom4j from 2.1.0 to 2.1.3

nnatarajan opened a new pull request #944:
URL: https://github.com/apache/fineract/pull/944


   ## Description
   @vorburger 
   
   Fails due to a ClasspathHellDuplicatesCheckRuleTest failure, but I not sure which of these libraries to exclude on the dependencies.gradle file?"
   
   
   org.apache.fineract.infrastructure.classdupes.ClasspathHellDuplicatesCheckRuleTest > classMethod FAILED
   
       junit.framework.AssertionFailedError: 16 Classpath duplicates detected:
   
       org/relaxng/datatype/helpers/DatatypeLibraryLoader$Service$Singleton.class
   
           jar:file:/Users/natasha/.gradle/caches/modules-2/files-2.1/relaxngDatatype/relaxngDatatype/20020414/de7952cecd05b65e0e4370cc93fc03035175eef5/relaxngDatatype-20020414.jar!/org/relaxng/datatype/helpers/DatatypeLibraryLoader$Service$Singleton.class
   
           jar:file:/Users/natasha/.gradle/caches/modules-2/files-2.1/com.sun.xml.bind/jaxb-osgi/2.3.0.1/57fd487367b130a35395d0ea0e765bfb1833902c/jaxb-osgi-2.3.0.1.jar!/org/relaxng/datatype/helpers/DatatypeLibraryLoader$Service$Singleton.class
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger closed pull request #944: FINERACT-966 Bump dom4j from 2.1.0 to 2.1.3

Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #944:
URL: https://github.com/apache/fineract/pull/944


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #944: FINERACT-966 Bump dom4j from 2.1.0 to 2.1.3

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #944:
URL: https://github.com/apache/fineract/pull/944#issuecomment-635590148


   @nnatarajan this was a tricky problem, it was easier for me to just fix it in a new #947 than explain how exactly to fix it here. I'm going to close this PR, but #947 includes your commit, for correct "attribution".


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org