You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2006/09/23 20:02:42 UTC
[Bug 5105] New: M::SA::Client doesn't always catch failed connection to spamd
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5105
Summary: M::SA::Client doesn't always catch failed connection to
spamd
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: Libraries
AssignedTo: spamassassin@dostech.ca
ReportedBy: spamassassin@dostech.ca
CC: dev@spamassassin.apache.org
Sometimes M::SA::Client fails to make a connection to spamd but still continues
on thinking that it has a connection and ends up spewing uninit'd warnings on
STDERR when it later tries to parse the response line. It appears to be a bug
with IO::Socket::INET, but we can easily avoid it.
IO::Socket::INET->new() and thus _create_connection() returns defined, even
though it didn't really get a connection.
One of the methods then sends something on the handle, without any reported error.
The method then reads from the handle... $line ends up being undef.
$line is then passed to _parse_response_line() which causes a bunch of warnings.
Checking to make sure $line is defined, which it always should be, takes care of
the problem.
Patch to follow.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 5105] [review] M::SA::Client doesn't always catch failed connection to spamd
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5105
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 |ready to commit
------- Additional Comments From sidney@sidney.com 2006-10-03 16:16 -------
+1
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 5105] [review] M::SA::Client doesn't always catch failed connection to spamd
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5105
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|M::SA::Client doesn't always|[review] M::SA::Client
|catch failed connection to |doesn't always catch failed
|spamd |connection to spamd
Status Whiteboard| |needs 2 votes
Target Milestone|Undefined |3.1.6
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 5105] M::SA::Client doesn't always catch failed connection to spamd
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5105
------- Additional Comments From spamassassin@dostech.ca 2006-09-23 18:03 -------
Created an attachment (id=3701)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3701&action=view)
suggested patch
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 5105] [review] M::SA::Client doesn't always catch failed connection to spamd
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5105
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1
------- Additional Comments From jm@jmason.org 2006-09-29 11:03 -------
+1
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 5105] [review] M::SA::Client doesn't always catch failed connection to spamd
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5105
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From spamassassin@dostech.ca 2006-10-03 16:21 -------
[dos@FC5-VPC trunk]$ svn ci -m "bug 5105: M::SA::Client doesn't always catch
failed connection to spamd, fixed"
Sending lib/Mail/SpamAssassin/Client.pm
Transmitting file data .
Committed revision 452674.
[dos@FC5-VPC 3.1]$ svn ci -m "bug 5105: M::SA::Client doesn't always catch
failed connection to spamd, fixed"
Sending lib/Mail/SpamAssassin/Client.pm
Transmitting file data .
Committed revision 452675.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.