You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/18 13:34:41 UTC

[GitHub] [airflow] AmarEL opened a new issue #8900: Info about the parameter "conf" when triggering a DAG

AmarEL opened a new issue #8900:
URL: https://github.com/apache/airflow/issues/8900


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   **Description**
   
   The information and examples about the optional JSON `conf` when triggering a dag from UI or by CLI needs to be included in the documentation.
   
   **Use case / motivation**
   
   I would like to have some reference in Docs since `conf` is not even mentioned as a parameter in the` create_dagrun` method in the specification of parameters. I would like to have too some examples of how to use `conf` in a DAG definition code since there is no section for that yet and some people, like me, would be missing this information about how to access this parameter.
   
   ```
       @provide_session
       def create_dagrun(self,
                         run_id,
                         state,
                         execution_date=None,
                         start_date=None,
                         external_trigger=False,
                         conf=None,
                         session=None):
           """
           Creates a dag run from this dag including the tasks associated with this dag.
           Returns the dag run.
           :param run_id: defines the run id for this dag run
           :type run_id: str
           :param execution_date: the execution date of this dag run
           :type execution_date: datetime.datetime
           :param state: the state of the dag run
           :type state: airflow.utils.state.State
           :param start_date: the date this dag run should be evaluated
           :type start_date: datetime
           :param external_trigger: whether this dag run is externally triggered
           :type external_trigger: bool
           :param session: database session
           :type session: sqlalchemy.orm.session.Session
           """
   ```
   **Related Issues**
   
   https://github.com/apache/airflow/pull/7312


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on issue #8900: Info about the parameter "conf" when triggering a DAG

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #8900:
URL: https://github.com/apache/airflow/issues/8900#issuecomment-630186616


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on issue #8900: Info about the parameter "conf" when triggering a DAG

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #8900:
URL: https://github.com/apache/airflow/issues/8900#issuecomment-640237729


   I added a tip in Web UI.
   https://github.com/apache/airflow/commits/master?after=b4b84a1933d055a2803b80b990482a7257a203ff+69
   What else should we do?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil closed issue #8900: Info about the parameter "conf" when triggering a DAG

Posted by GitBox <gi...@apache.org>.
kaxil closed issue #8900:
URL: https://github.com/apache/airflow/issues/8900


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on issue #8900: Info about the parameter "conf" when triggering a DAG

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8900:
URL: https://github.com/apache/airflow/issues/8900#issuecomment-642931893


   Related issue I had created:  https://github.com/apache/airflow/issues/9238#issue-637272825 -will add some more docs for 1.10.11 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] AmarEL commented on issue #8900: Info about the parameter "conf" when triggering a DAG

Posted by GitBox <gi...@apache.org>.
AmarEL commented on issue #8900:
URL: https://github.com/apache/airflow/issues/8900#issuecomment-640240858


   That works!
   But I think that adding the param `conf` and its type in the `create_dagrun` docstring would be more complete, because the `create_dagrun` method doesn't have this param in the docstring.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org