[jira] [Resolved] (GEODE-4326) Log Banner / AbstractConfig can fail to redact space-separated commandline arguments

["Patrick Rhomberg (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GEODE-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Rhomberg resolved GEODE-4326.
-------------------------------------
    Resolution: Not A Problem
      Assignee: Patrick Rhomberg

This portion of the JVM argument specification on the command-line does not allow space separation.

That is, while the command:
{noformat}
/path/to/bin/java -server -classpath /path/to/open/geode-assembly/build/install/apache-geode/lib/geode-core-1.5.0-SNAPSHOT.jar:/path/to/open/geode-assembly/build/install/apache-geode/lib/geode-dependencies.jar -Dgemfire.launcher.registerSignalHandlers=true -Djava.awt.headless=true -Dsun.rmi.dgc.server.gcInterval=9223372036854775806 -Dsecurity-password=mySecretPassword org.apache.geode.distributed.LocatorLauncher start defaultLocator --port=10334
{noformat}
will launch correctly and be correctly redacted, the same command with
{noformat}
[...] -Dsecurity-password mySecretPassword org.apache.geode.distributed.LocatorLauncher start defaultLocator --port=10334
{noformat}
is invalid and will fail at the command-line.

> Log Banner / AbstractConfig can fail to redact space-separated commandline arguments
> ------------------------------------------------------------------------------------
>
>                 Key: GEODE-4326
>                 URL: https://issues.apache.org/jira/browse/GEODE-4326
>             Project: Geode
>          Issue Type: Bug
>          Components: logging, security
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>            Priority: Major
>
> Because key-value pairs are assumed to be a single element in {{String[] args}}, and because these {{args}} are passed from the commandline, the case that the key and value are space-separated results in the value being considered a separate argument.  As such, it is not redacted, since redaction is driven by the key.
> While the {{ArgumentRedactor}} can handle space-separated lines as of completion of GEODE-4309, the {{args}} in question are new-line separated and will require some coercion to be handled by the {{ArgumentRedactor}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)