You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/10/28 17:56:58 UTC
[PR] fix changelog of common-io [airflow]
eladkal opened a new pull request, #35241:
URL: https://github.com/apache/airflow/pull/35241
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix changelog of common-io [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #35241:
URL: https://github.com/apache/airflow/pull/35241#issuecomment-1793746099
Now it fails because common.io had no tests at all (side effect of our missing test detection being broken as captured in #35442 . Added test in #35457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix changelog of common-io [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #35241:
URL: https://github.com/apache/airflow/pull/35241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix changelog of common-io [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #35241:
URL: https://github.com/apache/airflow/pull/35241#issuecomment-1793823975
The most difficult one-line-documentation-fix PR ever :D . Required some 3 PRs to pass the tests
:scream: :scream_cat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix changelog of common-io [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #35241:
URL: https://github.com/apache/airflow/pull/35241#issuecomment-1793829841
> > The most difficult one-line-documentation-fix PR ever :D . Required some 3 PRs to pass the tests
> > 😱 🙀
>
> I have unique skill to find the edge case of the edge case :)
But yeah. Thanks to that we have all the edge-cases fixed now. Keep on doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix changelog of common-io [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #35241:
URL: https://github.com/apache/airflow/pull/35241#issuecomment-1793827018
> The most difficult one-line-documentation-fix PR ever :D . Required some 3 PRs to pass the tests
>
> 😱 🙀
I have unique skill to find the edge case of the edge case :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org