[jira] [Commented] (HBASE-5620) Convert the client protocol of HRegionInterface to PB

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540644#comment-13540644 ] 

stack commented on HBASE-5620:
------------------------------

[~jxiang] In ClientProtocol (and AdminProtocol, etc.), was there a particular reason for implementing BlockingInterface?  See below:

{code}
+/**
+ * Protocol that a HBase client uses to communicate with a region server.
+ */
+@KerberosInfo(
+  serverPrincipal = "hbase.regionserver.kerberos.principal")
+@TokenInfo("HBASE_AUTH_TOKEN")
+@InterfaceAudience.Public
+@InterfaceStability.Evolving
+public interface ClientProtocol extends
+    ClientService.BlockingInterface, VersionedProtocol {
+  public static final long VERSION = 1L;
+}
{code}

For the annotations, @TokenInfo, @KerberosInfo, what made you add these?

Thanks Jimmy.  Just trying to figure out how we arrived at what we have in our Protocols.
                
> Convert the client protocol of HRegionInterface to PB
> -----------------------------------------------------
>
>                 Key: HBASE-5620
>                 URL: https://issues.apache.org/jira/browse/HBASE-5620
>             Project: HBase
>          Issue Type: Sub-task
>          Components: IPC/RPC, master, migration, regionserver
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: hbase-5620-sec.patch, hbase-5620_v3.patch, hbase-5620_v4.patch, hbase-5620_v4.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira