You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/01 08:29:28 UTC
[GitHub] [airflow] yyhecust opened a new pull request #16746: Fix an issue that can't backfill at 00:00
yyhecust opened a new pull request #16746:
URL: https://github.com/apache/airflow/pull/16746
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
when we use backfill api we can see in `dag_run = self._get_dag_run(next_run_date, session=session)` find dagrun by `run = DagRun.find(dag_id=self.dag.dag_id, execution_date=run_date, session=session)`，but next in `self._task_instances_for_dag_run(dag_run,session=session)` at `dag_run.refresh_from_db()` we use different method
to find dagrun, this results in different results for the two queries, this unable to find 00:00 backfill_dagrun, when we use same way we can find it.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #16746: Fix an issue that can't backfill at 00:00
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #16746:
URL: https://github.com/apache/airflow/pull/16746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16746: Fix an issue that can't backfill at 00:00
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16746:
URL: https://github.com/apache/airflow/pull/16746#issuecomment-899224084
We are no longer accepting patches to 1.10. If this is still an issue on the latest Airflow version (2.1.2 right now), please send a pull request to `main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16746: Fix an issue that can't backfill at 00:00
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16746:
URL: https://github.com/apache/airflow/pull/16746#issuecomment-899132187
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org