You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by GitBox <gi...@apache.org> on 2026/10/01 20:11:44 UTC
[GH] (grails-core/fix/15933-override-to-from-addresses): Workflow run "Build Health" is working again!
The GitHub Actions job "Build Health" on grails-core.git/fix/15933-override-to-from-addresses has succeeded.
Run started by GitHub user ruthst00 (triggered by jdaugherty).
Head commit for run:
8074a6ebd6524aa3b28b6f339442dd5e5f2bda0f / ruthes00 <ru...@gmail.com>
Three new Spock feature methods were added to `grails-mail/src/test/groovy/grails/plugins/mail/MailMessageBuilderSpec.groovy`, each pinning a previously untested behavioral decision in `MailMessageBuilder`:
1. "Test that overrideToAddress replaces cc and bcc recipients" — Confirms that `toDestinationAddresses()` is called for `cc()` and `bcc()` as well as `to()`, so `overrideToAddress` replaces every recipient address in all three fields, while `from` is left untouched.
2. "Test that overrideAddress overrides the explicit from address (backward-compatibility contract)" — Documents that when only `overrideAddress` is configured (no separate `overrideFromAddress`), it is promoted to `overrideFromAddress` in the constructor and therefore replaces an explicit `from` call in the DSL. This is the backward-compatibility contract that was previously implicit.
3. "Test that replyTo and envelopeFrom are not affected by overrideFromAddress or overrideAddress" — Explicitly asserts that `replyTo` and `envelopeFrom` pass through unchanged even when both `overrideAddress` and `overrideFromAddress` are set, making this a documented decision rather than an accident. (The `envelopeFrom` field is stored on the builder and applied at send time via `SMTPMessage`, so it is intentionally not subject to address overrides.)
All 23 tests in `MailMessageBuilderSpec` pass, and `codeStyle` reports no violations for the module.
Report URL: https://github.com/apache/grails-core/actions/runs/36890282466
With regards,
GitHub Actions via GitBox