[GitHub] [iceberg] coolderli commented on a change in pull request #2621: Core: Skip delete files when commit-status is unknown.

[GitBox <gi...@apache.org>]

coolderli commented on a change in pull request #2621:
URL: https://github.com/apache/iceberg/pull/2621#discussion_r637335791



##########
File path: core/src/main/java/org/apache/iceberg/actions/BaseRewriteDataFilesAction.java
##########
@@ -267,7 +268,10 @@ private void replaceDataFiles(Iterable<DataFile> deletedDataFiles, Iterable<Data
       RewriteFiles rewriteFiles = table.newRewrite();
       rewriteFiles.rewriteFiles(Sets.newHashSet(deletedDataFiles), Sets.newHashSet(addedDataFiles));
       commit(rewriteFiles);
-    } catch (Exception e) {
+    }  catch (CommitStateUnknownException e) {
+      LOG.warn("Skip delete files because we can not determine whether the commit was successful or not.");

Review comment:
       Agreed, I'll fix it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org